Address bot findings: args truthiness, hooks merge, JSDoc example

Author: felixweinberger

lefthook.yml

@@ -0,0 +1,42 @@
+# EXAMPLE USAGE:
+#
+#   Refer for explanation to following link:
+#   https://lefthook.dev/configuration/
+#
+# pre-push:
+#   jobs:
+#     - name: packages audit
+#       tags:
+#         - frontend
+#         - security
+#       run: yarn audit
+#
+#     - name: gems audit
+#       tags:
+#         - backend
+#         - security
+#       run: bundle audit
+#
+# pre-commit:
+#   parallel: true
+#   jobs:
+#     - run: yarn eslint {staged_files}
+#       glob: "*.{js,ts,jsx,tsx}"
+#
+#     - name: rubocop
+#       glob: "*.rb"
+#       exclude:
+#         - config/application.rb
+#         - config/routes.rb
+#       run: bundle exec rubocop --force-exclusion -- {all_files}
+#
+#     - name: govet
+#       files: git ls-files -m
+#       glob: "*.go"
+#       run: go vet -- {files}
+#
+#     - script: "hello.js"
+#       runner: node
+#
+#     - script: "hello.go"
+#       runner: go run

src/experimental/tasks/mcp-server.ts

@@ -60,10 +60,10 @@ export class ExperimentalMcpServerTasks {
      *     startBackgroundWork(task.taskId, args);
      *     return { task };
      *   },
-     *   getTask: async (args, extra) => {
+     *   getTask: async (extra) => {
      *     return extra.taskStore.getTask(extra.taskId);
      *   },
-     *   getTaskResult: async (args, extra) => {
+     *   getTaskResult: async (extra) => {
      *     return extra.taskStore.getTaskResult(extra.taskId);
      *   }
      * });

src/server/mcp.ts

@@ -109,7 +109,10 @@ export class McpServer {
                 return result;
             }
         };
-        this.server = new Server(serverInfo, { ...options, taskHandlerHooks });
+        this.server = new Server(serverInfo, {
+            ...options,
+            taskHandlerHooks: { ...options?.taskHandlerHooks, ...taskHandlerHooks }
+        });
     }
 
     private _getTaskHandler(taskId: string): ToolTaskHandler<ZodRawShapeCompat | undefined> | null {
@@ -1597,7 +1600,7 @@ function toolTaskHandlerByArgs<Args extends AnySchema | ZodRawShapeCompat | unde
 ): ToolTaskHandler<undefined> {
     return {
         createTask: extra =>
-            args // undefined only if tool.inputSchema is undefined
+            args !== undefined // undefined only if tool.inputSchema is undefined
                 ? Promise.resolve((handler as ToolTaskHandler<ZodRawShapeCompat>).createTask(args, extra))
                 : Promise.resolve((handler as ToolTaskHandler<undefined>).createTask(extra)),
         getTask: handler.getTask,