fix: address code review findings

- Add await to _clearTaskQueue calls in handleGetTaskPayload and
  handleCancelTask (was fire-and-forget, errors became unhandled rejections)
- Remove unused relatedRequestId parameter from sendOnResponseStream
  callback (Protocol already captures extra.requestId in closure)
- Remove dead assertTaskCapability/assertTaskHandlerCapability overrides
  from protocolTransportHandling.test.ts

Author: felixweinberger

packages/core/src/shared/protocol.ts

@@ -317,14 +317,9 @@ export abstract class Protocol<SendRequestT extends Request, SendNotificationT e
 
         this.setRequestHandler(GetTaskPayloadRequestSchema, async (request, extra) => {
             const capturedTransport = this._transport;
-            const result = await tm.handleGetTaskPayload(
-                request.params.taskId,
-                extra.sessionId,
-                extra.signal,
-                async (message, _relatedRequestId) => {
-                    await capturedTransport?.send(message, { relatedRequestId: extra.requestId });
-                }
-            );
+            const result = await tm.handleGetTaskPayload(request.params.taskId, extra.sessionId, extra.signal, async message => {
+                await capturedTransport?.send(message, { relatedRequestId: extra.requestId });
+            });
             return result as unknown as SendResultT;
         });
 

packages/core/src/shared/taskManager.ts

@@ -282,7 +282,7 @@ export class TaskManager {
         taskId: string,
         sessionId: string | undefined,
         signal: AbortSignal,
-        sendOnResponseStream: (message: JSONRPCNotification | JSONRPCRequest, relatedRequestId: RequestId) => Promise<void>
+        sendOnResponseStream: (message: JSONRPCNotification | JSONRPCRequest) => Promise<void>
     ): Promise<Result> {
         const handleTaskResult = async (): Promise<Result> => {
             // Deliver queued messages
@@ -310,10 +310,7 @@ export class TaskManager {
                     }
 
                     // Send non-response messages on the response stream
-                    await sendOnResponseStream(
-                        queuedMessage.message as JSONRPCNotification | JSONRPCRequest,
-                        0 as RequestId // placeholder, Protocol will use the actual requestId
-                    );
+                    await sendOnResponseStream(queuedMessage.message as JSONRPCNotification | JSONRPCRequest);
                 }
             }
 
@@ -328,7 +325,7 @@ export class TaskManager {
             }
 
             const result = await this._requireTaskStore.getTaskResult(taskId, sessionId);
-            this._clearTaskQueue(taskId);
+            await this._clearTaskQueue(taskId);
 
             return {
                 ...result,
@@ -366,7 +363,7 @@ export class TaskManager {
             }
 
             await this._requireTaskStore.updateTaskStatus(taskId, 'cancelled', 'Client cancelled task execution.', sessionId);
-            this._clearTaskQueue(taskId);
+            await this._clearTaskQueue(taskId);
 
             const cancelledTask = await this._requireTaskStore.getTask(taskId, sessionId);
             if (!cancelledTask) {

packages/core/test/shared/protocolTransportHandling.test.ts

@@ -38,8 +38,6 @@ describe('Protocol transport handling bug', () => {
             protected assertCapabilityForMethod(): void {}
             protected assertNotificationCapability(): void {}
             protected assertRequestHandlerCapability(): void {}
-            protected assertTaskCapability(): void {}
-            protected assertTaskHandlerCapability(): void {}
         })();
 
         transportA = new MockTransport('A');