fix: address review — assertCapability* params as RequestMethod|string for discoverability (KKonstantinov)

Author: felixweinberger

packages/client/src/client/client.ts

@@ -24,6 +24,7 @@ import type {
     NotificationMethod,
     ProtocolOptions,
     ReadResourceRequest,
+    RequestMethod,
     RequestOptions,
     Result,
     ServerCapabilities,
@@ -569,7 +570,7 @@ export class Client extends Protocol<ClientContext> {
         return this._instructions;
     }
 
-    protected assertCapabilityForMethod(method: string): void {
+    protected assertCapabilityForMethod(method: RequestMethod | string): void {
         switch (method as ClientRequest['method']) {
             case 'logging/setLevel': {
                 if (!this._serverCapabilities?.logging) {
@@ -632,7 +633,7 @@ export class Client extends Protocol<ClientContext> {
         }
     }
 
-    protected assertNotificationCapability(method: string): void {
+    protected assertNotificationCapability(method: NotificationMethod | string): void {
         switch (method as ClientNotification['method']) {
             case 'notifications/roots/list_changed': {
                 if (!this._capabilities.roots?.listChanged) {

packages/core/src/shared/protocol.ts

@@ -765,14 +765,14 @@ export abstract class Protocol<ContextT extends BaseContext> {
      *
      * This should be implemented by subclasses.
      */
-    protected abstract assertCapabilityForMethod(method: string): void;
+    protected abstract assertCapabilityForMethod(method: RequestMethod | string): void;
 
     /**
      * A method to check if a notification is supported by the local side, for the given method to be sent.
      *
      * This should be implemented by subclasses.
      */
-    protected abstract assertNotificationCapability(method: string): void;
+    protected abstract assertNotificationCapability(method: NotificationMethod | string): void;
 
     /**
      * A method to check if a request handler is supported by the local side, for the given method to be handled.

packages/server/src/server/server.ts

@@ -19,8 +19,10 @@ import type {
     LoggingLevel,
     LoggingMessageNotification,
     MessageExtraInfo,
+    NotificationMethod,
     NotificationOptions,
     ProtocolOptions,
+    RequestMethod,
     RequestOptions,
     ResourceUpdatedNotification,
     Result,
@@ -264,7 +266,7 @@ export class Server extends Protocol<ServerContext> {
         };
     }
 
-    protected assertCapabilityForMethod(method: string): void {
+    protected assertCapabilityForMethod(method: RequestMethod | string): void {
         switch (method) {
             case 'sampling/createMessage': {
                 if (!this._clientCapabilities?.sampling) {
@@ -297,7 +299,7 @@ export class Server extends Protocol<ServerContext> {
         }
     }
 
-    protected assertNotificationCapability(method: string): void {
+    protected assertNotificationCapability(method: NotificationMethod | string): void {
         switch (method) {
             case 'notifications/message': {
                 if (!this._capabilities.logging) {