Skip to content

Commit 6dd5629

Browse files
address review: remove NullTaskManager.onClose no-op override
The override prevented the base class _requestResolvers cleanup from running. Base TaskManager.onClose just clears two maps, which is cheap and correct for the null variant too.
1 parent 9ef0728 commit 6dd5629

1 file changed

Lines changed: 0 additions & 4 deletions

File tree

packages/core/src/shared/taskManager.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -894,8 +894,4 @@ export class NullTaskManager extends TaskManager {
894894
): Promise<{ queued: boolean; jsonrpcNotification?: JSONRPCNotification }> {
895895
return { queued: false, jsonrpcNotification: { ...notification, jsonrpc: '2.0' } };
896896
}
897-
898-
override onClose(): void {
899-
// No-op
900-
}
901897
}

0 commit comments

Comments
 (0)