fix(core): enforce SpecT result type on setRequestHandler (no loose-overload fallthrough)

The SpecT-typed overload's P constraint (StandardSchemaV1<SpecParams>) was too
tight to ever match real schemas, so calls always fell through to the loose
(method: string, schema, h: => Result) overload, silently accepting any return
type. Loosen overload 1's P to bare StandardSchemaV1 (params type still inferred
from the schema; only the result type is SpecT-constrained) and never-guard the
loose overload's method param against SpecRequests<SpecT> so spec-method calls
that don't satisfy the typed overload error instead of falling through. Same
guard on setNotificationHandler for symmetry. JSDoc updated; type tests added.

Author: felixweinberger

packages/core/src/shared/protocol.ts

@@ -1095,11 +1095,11 @@ export abstract class Protocol<ContextT extends BaseContext = BaseContext, SpecT
      *   no-params methods use `z.object({})`. `paramsSchema` may be any Standard Schema (Zod,
      *   Valibot, ArkType, etc.). The handler's `params` type is inferred from the passed
      *   `paramsSchema`; when `method` is listed in this instance's {@linkcode ProtocolSpec},
-     *   `paramsSchema`'s input and the handler's result type are constrained by `SpecT`.
+     *   the handler's result type is constrained to `SpecT`'s declared result.
      * - **Zod schema** — `setRequestHandler(RequestZodSchema, (request, ctx) => …)`. The method
      *   name is read from the schema's `method` literal; the handler receives the parsed request.
      */
-    setRequestHandler<K extends SpecRequests<SpecT>, P extends StandardSchemaV1<_Requests<SpecT>[K]['params']>>(
+    setRequestHandler<K extends SpecRequests<SpecT>, P extends StandardSchemaV1>(
         method: K,
         paramsSchema: P,
         handler: (
@@ -1111,8 +1111,8 @@ export abstract class Protocol<ContextT extends BaseContext = BaseContext, SpecT
         method: M,
         handler: (request: RequestTypeMap[M], ctx: ContextT) => Result | Promise<Result>
     ): void;
-    setRequestHandler<P extends StandardSchemaV1>(
-        method: string,
+    setRequestHandler<M extends string, P extends StandardSchemaV1>(
+        method: M extends SpecRequests<SpecT> ? never : M,
         paramsSchema: P,
         handler: (params: StandardSchemaV1.InferOutput<P>, ctx: ContextT) => Result | Promise<Result>
     ): void;
@@ -1237,12 +1237,10 @@ export abstract class Protocol<ContextT extends BaseContext = BaseContext, SpecT
      *
      * Mirrors {@linkcode setRequestHandler}: a two-arg spec-method form (handler receives the full
      * notification object), a three-arg form with a `paramsSchema` (handler receives validated
-     * `params`), and a Zod-schema form (method read from the schema's `method` literal). When the
-     * three-arg form's `method` is listed in this instance's {@linkcode ProtocolSpec},
-     * `paramsSchema`'s input is constrained by `SpecT`; the handler's `params` type is always
-     * inferred from the passed schema.
+     * `params`), and a Zod-schema form (method read from the schema's `method` literal). The
+     * handler's `params` type is always inferred from the passed schema.
      */
-    setNotificationHandler<K extends SpecNotifications<SpecT>, P extends StandardSchemaV1<_Notifications<SpecT>[K]['params']>>(
+    setNotificationHandler<K extends SpecNotifications<SpecT>, P extends StandardSchemaV1>(
         method: K,
         paramsSchema: P,
         handler: (params: StandardSchemaV1.InferOutput<P>) => void | Promise<void>
@@ -1251,8 +1249,8 @@ export abstract class Protocol<ContextT extends BaseContext = BaseContext, SpecT
         method: M,
         handler: (notification: NotificationTypeMap[M]) => void | Promise<void>
     ): void;
-    setNotificationHandler<P extends StandardSchemaV1>(
-        method: string,
+    setNotificationHandler<M extends string, P extends StandardSchemaV1>(
+        method: M extends SpecNotifications<SpecT> ? never : M,
         paramsSchema: P,
         handler: (params: StandardSchemaV1.InferOutput<P>) => void | Promise<void>
     ): void;

packages/core/test/shared/protocolSpec.test.ts

@@ -65,4 +65,17 @@ describe('ProtocolSpec typing', () => {
             return { ok: true };
         });
     });
+
+    it('typed-SpecT setRequestHandler enforces result type (no fallthrough to loose string overload)', () => {
+        const p = new TestProtocol<AppSpec>();
+        // @ts-expect-error -- result must be { opened: boolean }; string overload is `never`-guarded for spec methods
+        p.setRequestHandler('ui/open-link', z.object({ url: z.string() }), () => ({ ok: 'wrong-type' }));
+        // @ts-expect-error -- empty object doesn't satisfy { opened: boolean }
+        p.setRequestHandler('ui/open-link', z.object({ url: z.string() }), () => ({}));
+        // non-spec methods still allow loose Result
+        p.setRequestHandler('not/in-spec', z.object({}), () => ({ anything: 1 }));
+        // notifications: spec and non-spec both allow any schema and return void
+        p.setNotificationHandler('ui/size-changed', z.object({ width: z.number(), height: z.number() }), () => {});
+        p.setNotificationHandler('not/in-spec', z.object({ x: z.number() }), () => {});
+    });
 });