Skip to content

Commit e8d167a

Browse files
docs: fix stale Zod v3 / McpError references in REVIEW.md
1 parent a6a37ce commit e8d167a

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

REVIEW.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ review rounds and grows over time.
3333

3434
**Protocol & spec**
3535
- Types match [`schema.ts`](https://github.com/modelcontextprotocol/modelcontextprotocol/blob/main/schema/draft/schema.ts) exactly (optional vs required fields)
36-
- Correct `McpError` codes; HTTP status codes match spec (e.g., 404 vs 410)
36+
- Correct `ProtocolError` codes (enum `ProtocolErrorCode`); HTTP status codes match spec (e.g., 404 vs 410)
3737
- Works for both stdio and Streamable HTTP transports — no transport-specific assumptions
3838
- Cross-SDK consistency: check what `python-sdk` does for the same feature
3939

@@ -64,7 +64,7 @@ review rounds and grows over time.
6464

6565
### Schema Compliance
6666

67-
- When editing Zod protocol schemas in `schemas.ts`, verify unknown-key handling matches the spec `schema.ts`: if the spec type has no `additionalProperties: false`, the SDK schema must use `.passthrough()` / `.catchall(z.unknown())` rather than implicit strict — over-strict Zod (incl. `z.literal('object')` on `type`) rejects spec-valid payloads from other SDKs. Also confirm `spec.types.test.ts` still passes bidirectionally. (#1768, #1849, #1169)
67+
- When editing Zod protocol schemas in `schemas.ts`, verify unknown-key handling matches the spec `schema.ts`: if the spec type has no `additionalProperties: false`, the SDK schema must use `z.looseObject()` / `.catchall(z.unknown())` rather than implicit strict — over-strict Zod (incl. `z.literal('object')` on `type`) rejects spec-valid payloads from other SDKs. Also confirm `spec.types.test.ts` still passes bidirectionally. (#1768, #1849, #1169)
6868

6969
### Async / Lifecycle
7070

0 commit comments

Comments
 (0)