fix:close transport on connection failure#1862
Open
sid293 wants to merge 2 commits intomodelcontextprotocol:mainfrom
Open
fix:close transport on connection failure#1862sid293 wants to merge 2 commits intomodelcontextprotocol:mainfrom
sid293 wants to merge 2 commits intomodelcontextprotocol:mainfrom
Conversation
…during client connect
|
@modelcontextprotocol/client
@modelcontextprotocol/server
@modelcontextprotocol/express
@modelcontextprotocol/fastify
@modelcontextprotocol/hono
@modelcontextprotocol/node
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a resource leak on connection failure and resolves TypeScript error in
packages/client/test/client/auth.test.ts.Motivation and Context
client.ts: Movedsuper.connect()inside thetryblock so thecatchblock can properly close the transport if initialization fails.auth.test.ts: Addedas unknown as RequestInitto resolve a type mismatch on the optionalcacheproperty.How Has This Been Tested?
Added a new integration test to verify that the transport is closed even when startup fails.
All tests were verified passing using the workspace-wide command:
pnpm test:allBreaking Changes
none
Types of changes
Checklist
Additional context