fix(client): preserve OAuth resource metadata indicator#1989
Open
Genmin wants to merge 4 commits intomodelcontextprotocol:mainfrom
Open
fix(client): preserve OAuth resource metadata indicator#1989Genmin wants to merge 4 commits intomodelcontextprotocol:mainfrom
Genmin wants to merge 4 commits intomodelcontextprotocol:mainfrom
Conversation
🦋 Changeset detectedLatest commit: 41dd3a1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@modelcontextprotocol/client
@modelcontextprotocol/server
@modelcontextprotocol/express
@modelcontextprotocol/fastify
@modelcontextprotocol/hono
@modelcontextprotocol/node
commit: |
Author
|
Addressed the remaining build/release blockers:\n\n- Exported |
c22203a to
13e2065
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1968 by preserving the exact RFC 8707 resource indicator string published in protected resource metadata after validation, instead of serializing it through
URL.hrefand normalizing pathless origins to include a trailing slash.This keeps
resource=https://example.comdistinct fromresource=https://example.com/for authorization and token requests, which matters for OAuth providers that treat the resource/audience string literally.Validation
pnpm --filter @modelcontextprotocol/client test -- auth.test.tspnpm --filter @modelcontextprotocol/client typecheckpnpm --filter @modelcontextprotocol/client lintpnpm --filter @modelcontextprotocol/client build