fix: pass empty args to registerToolTask handler when no inputSchema#1509
Open
corvid-agent wants to merge 1 commit intomodelcontextprotocol:mainfrom
Open
fix: pass empty args to registerToolTask handler when no inputSchema#1509corvid-agent wants to merge 1 commit intomodelcontextprotocol:mainfrom
corvid-agent wants to merge 1 commit intomodelcontextprotocol:mainfrom
Conversation
🦋 Changeset detectedLatest commit: 16ff78a The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@modelcontextprotocol/client
@modelcontextprotocol/server
@modelcontextprotocol/express
@modelcontextprotocol/hono
@modelcontextprotocol/node
commit: |
…nputSchema
When registerToolTask is used without inputSchema, the createTask handler
should receive an empty object as its first argument when the handler
expects two arguments (args, ctx). This fixes the case where users define
a two-argument handler but omit inputSchema - previously the second
argument (ctx) would be passed as the first argument instead.
Uses Function.length to detect handler arity: single-arg handlers
continue to receive just ctx, while two-arg handlers get ({}, ctx).
Closes modelcontextprotocol#1471
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
corvid-agent
force-pushed
the
fix/register-tool-task-no-input-schema
branch
from
f144732 to
16ff78a
Compare
felixweinberger
requested changes
Mar 30, 2026
Contributor
felixweinberger
left a comment
felixweinberger
left a comment
There was a problem hiding this comment.
Thanks for this find - we shouldn't use Function.length to determine what state we're in, if we want to cleanly support this we should overload registerToolTask such that when inputSchema is absent it only accepts (ctx).
Want to refactor that instead of the runtime length check? Would also be great to have a test.
|
@claude review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
registerToolTaskto correctly pass({}, ctx)tocreateTaskhandlers that use a two-argument(args, ctx)signature when noinputSchemais providedFunction.lengthto detect handler arity: single-arg(ctx)handlers continue working as before, while two-arg(args, ctx)handlers receive an empty object as the first argumentCloses #1471
Test plan
registerToolTasktests with both single-arg and two-arg patterns)pnpm build:all)🤖 Generated with Claude Code