Skip to content

feat(server): add host process watchdog to StdioServerTransport #1712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
travisbreaks wants to merge 2 commits into
base: main
Choose a base branch
from
+57 −1

Merge branch 'main' into feat/server-orphan-detection

513efd2
Select commit
Loading
Failed to load commit list.
Open

feat(server): add host process watchdog to StdioServerTransport #1712

Merge branch 'main' into feat/server-orphan-detection
513efd2
Select commit
Loading
Failed to load commit list.
Claude / Claude Code Review completed May 1, 2026 in 6m 49s

Code review found 1 potential issue

Found 5 candidates, confirmed 1. See review comments for details.

Details

Severity Count
🔴 Important 0
🟡 Nit 1
🟣 Pre-existing 0
Severity File:Line Issue
🟡 Nit .changeset/server-host-watchdog.md:1-5 PR title/description describe abandoned watchdog approach, not the shipped stdin-EOF implementation

Annotations

Check warning on line 5 in .changeset/server-host-watchdog.md

See this annotation in the file changed.

@claude claude / Claude Code Review

PR title/description describe abandoned watchdog approach, not the shipped stdin-EOF implementation 

The PR title ("add host process watchdog") and description (clientProcessId, watchdogIntervalMs, `process.kill(pid, 0)` polling, `StdioServerTransportOptions`, constructor overloads, `unref()` timer, and the listed test plan) still describe the original implementation that was replaced on 2026-04-07 with the stdin-EOF approach — none of those exist in the shipped diff. Please update the PR title/body before merge so the squash-commit message matches what actually shipped; the changeset filename
View more details on Claude