-
Notifications
You must be signed in to change notification settings - Fork 1.8k
chore(deps): bump pnpm/action-setup from 4.3.0 to 5.0.0 #1794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
felixweinberger
merged 1 commit into
main
from
dependabot/github_actions/pnpm/action-setup-5.0.0
Mar 27, 2026
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 Nit: The version comment was changed from
# v4to# v5.0.0, but all other SHA-pinned actions in these workflow files use major-version-only comments (# v2,# v1). Consider using# v5for consistency.Extended reasoning...
What the issue is
The version comment on the
pnpm/action-setupSHA pin was changed from# v4(major-version-only) to# v5.0.0(full semver). This is inconsistent with the comment style used by every other SHA-pinned action in the same workflow files.Evidence of inconsistency
Looking at
.github/workflows/main.ymlalone, the other SHA-pinned actions use major-version-only comments:oven-sh/setup-bun@0c5077e51419868618aeaa5fe8019c62421857d6 # v2denoland/setup-deno@667a34cdef165d8d2b2e98dde39547c9daac7282 # v2And in
release.yml:changesets/action@6a0a831ff30acef54f2c6aa1cbbc1096b066edaf # v1The old value
# v4matched this convention. The new value# v5.0.0breaks it.Impact
This is purely cosmetic — the comment has no functional effect on which version is used (the SHA pin determines that). However, inconsistent comment styles make the workflow files slightly harder to scan and could cause confusion about whether the
.0.0suffix is meaningful.How to fix
Change all 11 occurrences of
# v5.0.0to# v5across the 6 workflow files. This is a Dependabot-generated PR, so Dependabot chose thev5.0.0format automatically — a quick find-and-replace before merging would restore consistency.Step-by-step proof
pnpm/action-setup@b906affcce14559ad1aafd4ab0e942779e9f58b1 # v4— major-only comment, consistent with other actions.pnpm/action-setup@fc06bc1257f339d1d5d8b3a19a8cae5388b55320 # v5.0.0— full semver comment, inconsistent.setup-bunon line 84 ofmain.yml:oven-sh/setup-bun@0c5077e51419868618aeaa5fe8019c62421857d6 # v2— major-only.