Skip to content

fix: address review comments — migration table shared/stdio row, serv…

86a6331
Select commit
Loading
Failed to load commit list.
Merged

refactor(client,server): move stdio transports to ./stdio subpath export #1871

fix: address review comments — migration table shared/stdio row, serv…
86a6331
Select commit
Loading
Failed to load commit list.
Claude / Claude Code Review completed Apr 17, 2026 in 13m 7s

Code review found 1 potential issue

Found 2 candidates, confirmed 1. See review comments for details.

Details

Severity Count
🔴 Important 0
🟡 Nit 1
🟣 Pre-existing 0
Severity File:Line Issue
🟡 Nit .changeset/stdio-subpath-export.md:6 Changeset prose overstates server-side impact

Annotations

Check warning on line 6 in .changeset/stdio-subpath-export.md

See this annotation in the file changed.

@claude claude / Claude Code Review

Changeset prose overstates server-side impact

The changeset prose says "The package root entries no longer pull in `node:child_process`, `node:stream`, or `cross-spawn`", but for `@modelcontextprotocol/server` this is inaccurate — the server root never pulled these in (server stdio has only a type-only `node:stream` import, no `node:child_process`, and no `cross-spawn` dependency). This is the same wording inaccuracy already corrected in three sibling locations (server `src/stdio.ts`, `src/index.ts`, `barrelClean.test.ts`) by c2b85dbd and 8