feat(compat): registerTool/registerPrompt accept raw Zod shape, auto-wrap with z.object() #1901
Claude / Claude Code Review
completed
Apr 27, 2026 in 15m 15s
Code review found 2 potential issues
Found 5 candidates, confirmed 2. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | packages/server/src/server/completable.ts:5-16 |
completable() widening: changeset omission + StandardSchemaV1 not publicly exported |
Annotations
Check warning on line 16 in packages/server/src/server/completable.ts
claude / Claude Code Review
completable() widening: changeset omission + StandardSchemaV1 not publicly exported
nit: aba1d39 widens the public `completable()`/`CompleteCallback`/`CompletableSchema` constraint from `StandardSchemaWithJSON` to `StandardSchemaV1`, but the changeset only mentions the raw-shape auto-wrap, and `StandardSchemaV1` isn't re-exported from `@modelcontextprotocol/core/public` (only `StandardSchemaWithJSON` is, at line 139) — so the new constraint on a public generic isn't itself importable from `@modelcontextprotocol/server`. Consider adding a sentence to the changeset and adding `St
Loading