docs: reframe migration guide as 'most servers: just bump' + 21 doc gaps#1910
Closed
felixweinberger wants to merge 2 commits into
Closed
docs: reframe migration guide as 'most servers: just bump' + 21 doc gaps#1910felixweinberger wants to merge 2 commits into
felixweinberger wants to merge 2 commits into
Claude / Claude Code Review
completed
Apr 30, 2026 in 25m 58s
Code review found 1 important issue
Found 5 candidates, confirmed 3. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 1 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🔴 Important | docs/migration.md:212-214 |
SSE Path-B callout: contradicts SKILL §3/§8, points at server-auth-legacy, and references a nonexistent 'example below' |
| 🟡 Nit | docs/migration.md:51 |
npx @modelcontextprotocol/codemod-v2 — uncited forward-reference reintroduced at :51 |
Annotations
Check failure on line 214 in docs/migration.md
claude / Claude Code Review
SSE Path-B callout: contradicts SKILL §3/§8, points at server-auth-legacy, and references a nonexistent 'example below'
The new Path B SSE callout has three problems in one sentence: (1) it contradicts SKILL.md — d556ce5 reverted SKILL §3 to `server/sse.js` → "REMOVED (migrate to Streamable HTTP)" and §8 to "`SSEServerTransport` removed entirely", so migration.md offers Path B users an SSE escape hatch while SKILL.md (the LLM-applied Path B procedure) says none exists; (2) it routes SSE users to `@modelcontextprotocol/server-auth-legacy` (which your own forward-ref map assigns to #1908, the **auth** package), not
Check warning on line 51 in docs/migration.md
claude / Claude Code Review
npx @modelcontextprotocol/codemod-v2 — uncited forward-reference reintroduced at :51
🟡 nit: Same uncited-codemod issue previously flagged for `mcp-codemod v1-to-v2` at :251 (resolved by dropping it) has reappeared here under a different name — `npx @modelcontextprotocol/codemod-v2` has no implementation in the monorepo and no cited v2-bc companion PR (unlike #1887/#1903/#1906/#1907/#1908/#1909/#1913/#1916/#1917). The table above already links each item to its manual fix, so the sentence stands without the parenthetical; either cite the PR that ships `@modelcontextprotocol/codemo
Loading