fix: respect disabled listChanged capabilities on v1.x#1948
Open
paulelliotco wants to merge 1 commit intomodelcontextprotocol:v1.xfrom
Open
fix: respect disabled listChanged capabilities on v1.x#1948paulelliotco wants to merge 1 commit intomodelcontextprotocol:v1.xfrom
paulelliotco wants to merge 1 commit intomodelcontextprotocol:v1.xfrom
Conversation
|
commit: |
Preserve explicit listChanged:false settings in McpServer, gate list-changed notifications on the advertised capability, and add regression coverage for both capability values and runtime notification behavior.
67facd2 to
843c76f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
listChanged: falsesettings whenMcpServerregisters tool, resource, and prompt capabilitiesnotifications/*/list_changedwhen the corresponding capability is not advertisedServer.getCapabilities()Fixes #1819
Testing
npm run lintnpx vitest run test/server/mcp.test.tsNotes
npm run typecheckstill fails on pre-existing unrelated test call signatures intest/integration-tests/taskLifecycle.test.tsandtest/shared/protocol.test.ts