Skip to content

[comparison] specTypeSchema/isSpecType as string-arg functions #1979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
felixweinberger wants to merge 14 commits into from

refactor(specTypeSchema): switch isSpecType/specTypeSchema to string-…

d7a5c96
Select commit
Loading
Failed to load commit list.
Closed

[comparison] specTypeSchema/isSpecType as string-arg functions #1979

refactor(specTypeSchema): switch isSpecType/specTypeSchema to string-…
d7a5c96
Select commit
Loading
Failed to load commit list.
Claude / Claude Code Review completed Apr 30, 2026 in 7m 14s

Code review found 1 potential issue

Found 3 candidates, confirmed 1. See review comments for details.

Details

Severity Count
🔴 Important 0
🟡 Nit 1
🟣 Pre-existing 0
Severity File:Line Issue
🟡 Nit docs/migration.md:719-734 Unrelated Prettier reformatting inflates the comparison diff

Annotations

Check warning on line 734 in docs/migration.md

See this annotation in the file changed.

@claude claude / Claude Code Review

Unrelated Prettier reformatting inflates the comparison diff 

nit: Several hunks in `docs/migration.md` and `docs/migration-SKILL.md` are pure Prettier reformatting unrelated to the `isSpecType`/`specTypeSchema` change — this SdkErrorCode table re-padding, the `items: [/* ... */]` code-block reflow at 382-389/397-402, the prose re-wraps at 140-141/441-442, and the Types/shared-imports table re-padding in `migration-SKILL.md`. Since the PR's stated purpose is that the diff against #1887 "shows only the API-shape delta", it'd be worth running Prettier on the
View more details on Claude