fix(server): accept structurally compatible Zod v4 schemas#1990
Open
Genmin wants to merge 3 commits intomodelcontextprotocol:v1.xfrom
Open
fix(server): accept structurally compatible Zod v4 schemas#1990Genmin wants to merge 3 commits intomodelcontextprotocol:v1.xfrom
Genmin wants to merge 3 commits intomodelcontextprotocol:v1.xfrom
Conversation
🦋 Changeset detectedLatest commit: bfc7eb8 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
Author
|
Added the missing patch changeset for the v1.x SDK package so the release-metadata blocker should clear on the next checks run. The code checks were already green before this metadata-only update. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1987 on the
v1.xbranch by avoiding a type-identity leak from the SDK's ownzod/v4/coreimport in the public Zod compatibility types.AnySchemanow accepts Zod v4 schemas structurally via the_zod.input/_zod.outputcontract. This preserves inference forregisterToolraw shapes while allowing projects whose package manager resolves a different compatible Zod v4 copy than the SDK's copy.Validation
zod@4.4.1and a nested SDK-resolvedzod@4.3.6:registerToolfailed withZodStringnot assignable toAnySchema.npx tsc --noEmitpassed and callback args inferred correctly.npm run typechecknpm run buildnpm test -- test/issues/test_1987_zod_v4_type_identity.test.ts test/server/mcp.test.ts test/server/completable.test.tsnpm run lint