Spell out MAP-Lang correctly, and minor cleanup#10
Open
henrikt-ma wants to merge 4 commits into
Open
Conversation
Author
|
@HansOlsson I am unable to add reviewers to this PR, but maybe pinging works? |
a1785c5 to
ebcc2fd
Compare
HansOlsson
reviewed
Jun 3, 2026
| Development, standardization and promoting of the object-oriented modeling language Modelica to model | ||
| and simulate multi-domain cyber physical systems in a convenient way. | ||
|
|
||
| Development, standardization and promoting of the object-oriented modeling language Modelica to model and simulate multi-domain cyber physical systems in a convenient way. |
Contributor
There was a problem hiding this comment.
This sentence was bad at the start as well (Development and promoting...).
We either open a new PR or fix that here, e.g.;
Suggested change
| Development, standardization and promoting of the object-oriented modeling language Modelica to model and simulate multi-domain cyber physical systems in a convenient way. | |
| Developing, standardizing, and promoting the object-oriented modeling language Modelica to model and simulate multi-domain cyber physical systems in a convenient way. |
Author
There was a problem hiding this comment.
We might as well fix it now, but your suggestion only addresses the problems at the start of the sentence. The beginning and end of the sentence are still not connected in a sensical way. This would be better:
Suggested change
| Development, standardization and promoting of the object-oriented modeling language Modelica to model and simulate multi-domain cyber physical systems in a convenient way. | |
| Support convenient modeling and simulation of multi-domain cyber physical systems by developing, standardizing, and promoting the object-oriented modeling language Modelica. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.