Skip to content

Demonstrate PolyphaseInitialization#4718

Open
AHaumer wants to merge 8 commits into
modelica:masterfrom
AHaumer:PolyPhaseInitialization
Open

Demonstrate PolyphaseInitialization#4718
AHaumer wants to merge 8 commits into
modelica:masterfrom
AHaumer:PolyPhaseInitialization

Conversation

@AHaumer

@AHaumer AHaumer commented Jan 7, 2026

Copy link
Copy Markdown
Contributor

Addresses #4457 to have an explanation and an example how polyphase initialiuation is implemented.

@AHaumer AHaumer added this to the maintenance milestone Jan 7, 2026
@AHaumer AHaumer self-assigned this Jan 7, 2026
@AHaumer AHaumer added enhancement New feature or enhancement documentation Issue addresses the documentation example Issue only addresses example(s) L: Electrical.Polyphase Issue addresses Modelica.Electrical.Polyhase V: 4.2.0-dev Issue originates in MSL v4.2.0-dev (and is not present in earlier releases) labels Jan 7, 2026

@henrikt-ma henrikt-ma left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I don't know enough about polyphase inductor currents to review this without further guidance about what to keep an eye on.

@AHaumer

AHaumer commented Jan 8, 2026

Copy link
Copy Markdown
Contributor Author

@henrikt-ma is not a question on correct initialization, but on conformity to standard and usability,
The example demonstrates the usage of the solution we already agreed on.

@maltelenz maltelenz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be really nice if a figure could be added as well!

Comment thread Modelica/Electrical/Polyphase/Examples/PolyphaseInitialization.mo Outdated
Comment thread Modelica/Electrical/Polyphase/Examples/PolyphaseInitialization.mo Outdated
Comment thread Modelica/Electrical/Polyphase/Examples/PolyphaseInitialization.mo Outdated
Comment thread Modelica/Electrical/Polyphase/Examples/PolyphaseInitialization.mo Outdated
AHaumer and others added 3 commits January 8, 2026 16:44
Co-authored-by: Malte Lenz <malte.lenz@gmail.com>
Co-authored-by: Malte Lenz <malte.lenz@gmail.com>
Co-authored-by: Malte Lenz <malte.lenz@gmail.com>
@AHaumer

AHaumer commented Jan 8, 2026

Copy link
Copy Markdown
Contributor Author

It would be really nice if a figure could be added as well!

Do you mean in the example? The diagramm layer acts as the figure. Should I draw a nicer one?

@maltelenz

Copy link
Copy Markdown
Contributor

It would be really nice if a figure could be added as well!

Do you mean in the example? The diagramm layer acts as the figure. Should I draw a nicer one?

I meant a figure in the sense of the Documentation.figure annotation. In other words, the specifications for an easily accessible plot with the interesting variables to look at and an accompanying caption. Since you have access to System Modeler, I can recommend using Simulation Center to create one using a friendly interface :-).

@AHaumer

AHaumer commented Jan 8, 2026

Copy link
Copy Markdown
Contributor Author

I meant a figure in the sense of the Documentation.figure annotation. In other words, the specifications for an easily accessible plot with the interesting variables to look at and an accompanying caption. Since you have access to System Modeler, I can recommend using Simulation Center to create one using a friendly interface :-).

This example is more about "How is initialization of a polyphase system done?" and not so much about the results.
Well I'll give this a try.

@maltelenz

Copy link
Copy Markdown
Contributor

I guess plotting the variables that were initialized makes sense?

After getting used to having ready-made plots available for most examples I encounter (System Modeler has had figures for a long time, and we routinely add them to any models we build), arriving in the simulation environment with just a mass of variables and having to start digging for what to plot, has become somewhat of a shock :)

Comment thread Modelica/Electrical/Polyphase/Examples/PolyphaseInitialization.mo Outdated

@HansOlsson HansOlsson left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the minor note it looks good.

I very much agree and I hope @AHaumer agrees as well

Co-authored-by: Hans Olsson <HansOlsson@users.noreply.github.com>

@christiankral christiankral left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The proposal looks good to me

@AHaumer

AHaumer commented Feb 25, 2026

Copy link
Copy Markdown
Contributor Author

@casella we need an other reviewer than christiankral since we was the last pusher ...

@maltelenz

Copy link
Copy Markdown
Contributor

I meant a figure in the sense of the Documentation.figure annotation. In other words, the specifications for an easily accessible plot with the interesting variables to look at and an accompanying caption. Since you have access to System Modeler, I can recommend using Simulation Center to create one using a friendly interface :-).

This example is more about "How is initialization of a polyphase system done?" and not so much about the results. Well I'll give this a try.

@AHaumer Did you give this a try?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Issue addresses the documentation enhancement New feature or enhancement example Issue only addresses example(s) L: Electrical.Polyphase Issue addresses Modelica.Electrical.Polyhase V: 4.2.0-dev Issue originates in MSL v4.2.0-dev (and is not present in earlier releases)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants