Skip to content

Commit eea50d4

Browse files
committed
refactor: move multiturn config to backbone and add defensive checks
1 parent 5b79394 commit eea50d4

File tree

5 files changed

+12
-1072
lines changed

5 files changed

+12
-1072
lines changed
File renamed without changes.

ajet/backbone/verl/seqlen_balancing.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -196,9 +196,9 @@ def greedy_partition(seqlen_list: list[int], k_partitions: int, equal_size: bool
196196
partitions = [[] for _ in range(k_partitions)]
197197
partition_sums = [0 for _ in range(k_partitions)]
198198
for seqlen, i in sorted_seqlen:
199-
min_idx = None
200-
for j in range(k_partitions):
201-
if min_idx is None or partition_sums[j] < partition_sums[min_idx]:
199+
min_idx = 0
200+
for j in range(1, k_partitions):
201+
if partition_sums[j] < partition_sums[min_idx]:
202202
min_idx = j
203203
partitions[min_idx].append(i)
204204
partition_sums[min_idx] += seqlen
@@ -295,7 +295,7 @@ def log_seqlen_unbalance(seqlen_list: list[int], partitions: list[list[int]], pr
295295
return {
296296
f"{prefix}/min": min_sum_seqlen,
297297
f"{prefix}/max": max_sum_seqlen,
298-
f"{prefix}/minmax_diff": max_sum_seqlen - min_sum_seqlen,
298+
f"{prefix}/minmax_diff": max_sum_seqlen - min_sum_seqlen, # type: ignore[operator]
299299
f"{prefix}/balanced_min": min_sum_seqlen_balanced,
300300
f"{prefix}/balanced_max": max_sum_seqlen_balanced,
301301
f"{prefix}/mean": total_sum_seqlen / len(partitions),

ajet/default_config/verl/verl_default.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -297,7 +297,7 @@ actor_rollout_ref:
297297
'n': 1
298298
do_sample: false
299299
multi_turn:
300-
_target_: ajet.default_config.verl.config_schema_rollout.AjetMultiTurnConfig
300+
_target_: ajet.backbone.verl.multiturn_config.AjetMultiTurnConfig
301301
enable: false
302302
max_assistant_turns: null
303303
tool_config_path: null

0 commit comments

Comments
 (0)