Fix Head modulation broadcast for batch size > 1 in WanModel#1517
Open
HaozheZhang6 wants to merge 1 commit into
Open
Fix Head modulation broadcast for batch size > 1 in WanModel#1517HaozheZhang6 wants to merge 1 commit into
HaozheZhang6 wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request modifies the forward method in diffsynth/models/wan_video_dit.py to unsqueeze t_mod along the second dimension (dim=1) before adding it to self.modulation in the else branch, ensuring correct shape alignment for the tensor addition. There are no review comments to evaluate, and I have no additional feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1516.
Head.forwardonly works for batch size 1 whent_modis 2D(b, dim).self.modulationis(1, 2, dim), somodulation + t_modbroadcasts(1, 2, dim)against(b, dim): the2andbdims line up, so it silently mismatches at b=2 and raises at b>=3. The normal forward path hits this —self.head(x, t)passes the per-sample time embeddingtof shape(b, dim).Unsqueeze
t_modto(b, 1, dim)so it broadcasts against(1, 2, dim)->(b, 2, dim), matching the 3D branch just above. b=1 output is unchanged and the 3D per-token branch is untouched.Repro on current main (raises at b>=3):