Skip to content

Commit b710ffd

Browse files
committed
fix: handle None scheduler_conf in trainer, add scheduler to VAD finetune
- Fix TypeError when scheduler_conf is not provided (NoneType unpacking) - Add explicit scheduler and scheduler_conf to VAD finetune.sh - Fixes user report in #2961
1 parent 89df04b commit b710ffd

2 files changed

Lines changed: 4 additions & 2 deletions

File tree

examples/industrial_data_pretraining/fsmn_vad_streaming/finetune.sh

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -61,4 +61,6 @@ torchrun \
6161
++train_conf.avg_nbest_model=3 \
6262
++train_conf.use_deepspeed=false \
6363
++optim_conf.lr=0.00005 \
64+
++scheduler="warmuplr" \
65+
++scheduler_conf.warmup_steps=1000 \
6466
++output_dir="${output_dir}" &> ${log_file}

funasr/train_utils/trainer_ds.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1018,7 +1018,7 @@ def warp_optim_scheduler(self, model, **kwargs):
10181018
scheduler = kwargs.get("scheduler", "warmuplr")
10191019
assert scheduler in scheduler_classes
10201020
scheduler_class = scheduler_classes.get(scheduler)
1021-
scheduler = scheduler_class(optim, **kwargs.get("scheduler_conf"))
1021+
scheduler = scheduler_class(optim, **(kwargs.get("scheduler_conf") or {}))
10221022

10231023
if self.use_deepspeed:
10241024
import deepspeed
@@ -1047,7 +1047,7 @@ def scheduler(opt):
10471047
Args:
10481048
opt: TODO.
10491049
"""
1050-
return scheduler_class(opt, **kwargs.get("scheduler_conf"))
1050+
return scheduler_class(opt, **(kwargs.get("scheduler_conf") or {}))
10511051

10521052
model, optimizer, _, scheduler = deepspeed.initialize(
10531053
args=args,

0 commit comments

Comments
 (0)