Skip to content

Commit e942b79

Browse files
authored
Mark assisted review gate integrations (#3089)
1 parent 4ede0ac commit e942b79

2 files changed

Lines changed: 44 additions & 2 deletions

File tree

scripts/collect_growth_metrics.py

Lines changed: 16 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,18 @@
7373
"infiniflow/ragflow#16473": {
7474
"reason": "review evidence already posted; avoid duplicate pings",
7575
},
76+
"run-llama/llama_index#21958": {
77+
"reason": "review evidence already posted; avoid duplicate pings",
78+
},
79+
"mudler/LocalAI#10090": {
80+
"reason": "review evidence already posted; avoid duplicate pings",
81+
},
82+
"ray-project/ray#64053": {
83+
"reason": "review evidence already posted; avoid duplicate pings",
84+
},
85+
"agno-agi/agno#8501": {
86+
"reason": "review evidence already posted; avoid duplicate pings",
87+
},
7688
"lukasmasuch/best-of-ml-python#455": {
7789
"reason": "review evidence already posted; avoid duplicate pings",
7890
},
@@ -85,6 +97,9 @@
8597
"tmoroney/auto-subs#629": {
8698
"reason": "review evidence already posted; avoid duplicate pings",
8799
},
100+
"pipecat-ai/pipecat#4844": {
101+
"reason": "review evidence already posted; avoid duplicate pings",
102+
},
88103
}
89104
REPORTER_WAITING_LABELS = {"needs feedback"}
90105
CONTRIBUTOR_WAITING_LABELS = {"good first issue", "help wanted", "ready for PR"}
@@ -293,7 +308,7 @@ def recommend_integration_action(
293308
if (
294309
known_assisted_review_reason
295310
and check_state in {"success", "unknown"}
296-
and mergeable_state in {"clean", "unknown", None}
311+
and mergeable_state in {"blocked", "clean", "unknown", "unstable", None}
297312
):
298313
return "wait for maintainer review"
299314

tests/test_collect_growth_metrics.py

Lines changed: 28 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -497,6 +497,20 @@ def test_known_assisted_review_requests_include_validated_discovery_prs():
497497
assert expected_prs.issubset(set(module.KNOWN_ASSISTED_REVIEW_REQUESTS))
498498

499499

500+
def test_known_assisted_review_requests_include_validated_review_gate_prs():
501+
module = load_growth_metrics_module()
502+
503+
expected_prs = {
504+
"run-llama/llama_index#21958",
505+
"mudler/LocalAI#10090",
506+
"ray-project/ray#64053",
507+
"agno-agi/agno#8501",
508+
"pipecat-ai/pipecat#4844",
509+
}
510+
511+
assert expected_prs.issubset(set(module.KNOWN_ASSISTED_REVIEW_REQUESTS))
512+
513+
500514
def test_collect_integration_metrics_marks_known_assisted_review_request(monkeypatch):
501515
module = load_growth_metrics_module()
502516

@@ -730,6 +744,18 @@ def test_recommend_integration_action_treats_blocked_unknown_checks_as_review_ga
730744
assert action == "review gate"
731745

732746

747+
def test_recommend_integration_action_waits_for_maintainer_after_assisted_blocked_review_gate():
748+
module = load_growth_metrics_module()
749+
750+
action = module.recommend_integration_action(
751+
{"state": "open", "draft": False, "mergeable_state": "blocked"},
752+
{"state": "success", "failed_check_runs": [], "pending_check_runs": []},
753+
known_assisted_review_reason="review evidence already posted; avoid duplicate pings",
754+
)
755+
756+
assert action == "wait for maintainer review"
757+
758+
733759
def test_recommend_integration_action_treats_clean_unknown_checks_as_request_review():
734760
module = load_growth_metrics_module()
735761

@@ -1221,4 +1247,5 @@ def fake_fetch_json(url, headers=None):
12211247
assert integration["repo_stars"] == 36_000
12221248
assert integration["repo_forks"] == 6_800
12231249
assert integration["checks"]["state"] == "success"
1224-
assert integration["next_action"] == "request review"
1250+
assert integration["next_action"] == "wait for maintainer review"
1251+
assert integration["known_assisted_review_reason"] == "review evidence already posted; avoid duplicate pings"

0 commit comments

Comments
 (0)