Skip to content

update requirements #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jintao-Huang merged 1 commit into from
Apr 23, 2026
Merged

update requirements #51

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
megatron-core>=0.12
modelscope
peft>=0.11,<0.19
peft>=0.11,<0.20
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot Apr 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The packaging library is imported in src/mcore_bridge/patcher.py and src/mcore_bridge/tuners/lora.py but is not listed as a direct dependency in requirements.txt. It is best practice to explicitly declare all direct dependencies to ensure environment consistency and avoid potential ImportError if transitive dependencies change.

peft>=0.11,<0.20
packaging

safetensors
tqdm
transformers>=4.33,<5.6.0
transformers>=4.33,<5.7.0
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot Apr 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The upper bound constraint <5.7.0 for transformers is unconventional. Since transformers is currently in the 4.x series, a major version release (5.0.0) is expected to contain breaking changes. Given that this project performs extensive monkey-patching on internal APIs, it is safer to restrict the dependency to the current major version (e.g., <5.0.0) unless compatibility with 5.x has been explicitly verified.

transformers>=4.33,<5.0.0

Loading