Skip to content

[model] support hy_v3#53

Merged
Jintao-Huang merged 6 commits intomodelscope:mainfrom
Jintao-Huang:support_hy_v3
Apr 28, 2026
Merged

[model] support hy_v3#53
Jintao-Huang merged 6 commits intomodelscope:mainfrom
Jintao-Huang:support_hy_v3

Conversation

@Jintao-Huang
Copy link
Copy Markdown
Collaborator

No description provided.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for the Hunyuan (hy_v3) model by updating the documentation, adding the model type to the constants, and implementing the HyV3Bridge class. Review feedback suggests refining the HuggingFace weight keys to ensure correct loading and expanding the list of supported model types to improve automatic recognition of standard Hunyuan checkpoints.

Comment thread src/mcore_bridge/model/gpts/hunyuan.py
Comment thread src/mcore_bridge/model/gpts/hunyuan.py
@Jintao-Huang
Copy link
Copy Markdown
Collaborator Author

/gemini review

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for the Hunyuan (hy_v3) model by adding the HyV3Bridge class, updating model constants, and expanding the configuration parser to support new parameters such as moe_router_use_sigmoid, router_scaling_factor, and qk_norm. A critical logic error was found in the configuration parser where the moe_router_score_function is unconditionally set to 'sigmoid' if the moe_router_use_sigmoid key exists, regardless of its boolean value.

Comment thread src/mcore_bridge/config/parser.py Outdated
@Jintao-Huang Jintao-Huang merged commit 60503a2 into modelscope:main Apr 28, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants