[megatron] Support deepseek-v4 megatron#9386
Open
Jintao-Huang wants to merge 2 commits into
Open
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the documentation to indicate support for DeepSeek-V4 models and adds new configuration arguments to the MegatronArguments class, such as csa_dense_mode and use_fused_mhc. A suggestion was made to improve code readability by adding a blank line before the new DeepSeek-V4 argument section in megatron_args.py to maintain consistent formatting.
| # dsa | ||
| dsa_indexer_loss_coeff: Optional[float] = None | ||
| dsa_indexer_use_sparse_loss: bool = False | ||
| # deepseek-v4 |
Contributor
There was a problem hiding this comment.
Add a blank line before the # deepseek-v4 comment to maintain consistent section separation and improve readability. The previous section (dsa) ends at line 626, and a blank line would help distinguish the new group of arguments, following the style used for the # other section below.
Suggested change
| # deepseek-v4 | |
| # deepseek-v4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
modelscope/mcore-bridge#86