ci: fix TMPDIR override, set -e exit capture, redundant glob

- Rename TMPDIR to BUILD_DIR to avoid clobbering POSIX env var
- Use 'cmd && RC=0 || RC=$?' pattern so set -e doesn't skip cleanup
- Remove redundant CONTRIBUTING.md from docs-only case patterns (*.md covers it)

Author: benvinegar

.github/workflows/install-smoke.yml

@@ -43,7 +43,7 @@ jobs:
           while IFS= read -r path; do
             [ -z "$path" ] && continue
             case "$path" in
-              docs/*|*.md|*.mdx|LICENSE|CONTRIBUTING.md)
+              docs/*|*.md|*.mdx|LICENSE)
                 continue
                 ;;
               *)

.github/workflows/integration.yml

@@ -43,7 +43,7 @@ jobs:
           while IFS= read -r path; do
             [ -z "$path" ] && continue
             case "$path" in
-              docs/*|*.md|*.mdx|LICENSE|CONTRIBUTING.md)
+              docs/*|*.md|*.mdx|LICENSE)
                 continue
                 ;;
               *)

bin/ci/install-smoke-docker.sh

@@ -25,11 +25,11 @@ fi
 
 # ── Build context ────────────────────────────────────────────────────────────
 
-TMPDIR=$(mktemp -d)
-trap 'rm -rf "$TMPDIR"' EXIT
+BUILD_DIR=$(mktemp -d)
+trap 'rm -rf "$BUILD_DIR"' EXIT
 
 # Create tarball excluding unnecessary files
-tar czf "$TMPDIR/src.tar.gz" \
+tar czf "$BUILD_DIR/src.tar.gz" \
   -C "$REPO_DIR" \
   --exclude=node_modules \
   --exclude=.git \
@@ -39,7 +39,7 @@ tar czf "$TMPDIR/src.tar.gz" \
 
 # ── Dockerfile ───────────────────────────────────────────────────────────────
 
-cat > "$TMPDIR/Dockerfile" <<'DOCKERFILE'
+cat > "$BUILD_DIR/Dockerfile" <<'DOCKERFILE'
 FROM ubuntu:24.04
 
 ENV DEBIAN_FRONTEND=noninteractive
@@ -80,7 +80,7 @@ DOCKERFILE
 
 # ── Verification script ─────────────────────────────────────────────────────
 
-cat > "$TMPDIR/verify.sh" <<'VERIFY'
+cat > "$BUILD_DIR/verify.sh" <<'VERIFY'
 #!/bin/bash
 set -euo pipefail
 
@@ -154,12 +154,11 @@ VERIFY
 IMAGE_TAG="baudbot-install-smoke:$(date +%s)"
 
 echo "Building Docker image..."
-docker build -t "$IMAGE_TAG" "$TMPDIR" 2>&1 | tail -5
+docker build -t "$IMAGE_TAG" "$BUILD_DIR" 2>&1 | tail -5
 
 echo ""
 echo "Running verification..."
-docker run --rm "$IMAGE_TAG" /verify.sh
-RC=$?
+docker run --rm "$IMAGE_TAG" /verify.sh && RC=0 || RC=$?
 
 # Cleanup image
 docker rmi "$IMAGE_TAG" >/dev/null 2>&1 || true