deploy: fix update-release release-root metadata path leak

[benvinegar]

Summary

• fix bin/update-release.sh so release paths are normalized after env/CLI parsing
• ensure BAUDBOT_RELEASE_ROOT wins over inherited BAUDBOT_SOURCE_* variables
• remove early cached source metadata path locals and use BAUDBOT_SOURCE_URL_FILE / BAUDBOT_SOURCE_BRANCH_FILE at point of use
• add regression coverage in bin/update-release.test.sh for stale source-path env vars

Validation

• bin/update-release.test.sh
• bin/rollback-release.test.sh
• npm run test:shell
• npm run lint:shell (fails locally: shellcheck not installed in PATH)

[greptile-apps]

Greptile Summary

Fixed a path leak in bin/update-release.sh where --release-root would incorrectly inherit stale BAUDBOT_SOURCE_* environment variables instead of using paths derived from the provided release root. The fix:

• Removed early caching of source metadata path locals that were set before CLI argument parsing
• Moved bb_refresh_release_paths call to after all argument parsing completes
• Changed --release-root handler to set BAUDBOT_RELEASE_ROOT instead of immediately calling refresh
• Updated all source path references to use $BAUDBOT_SOURCE_URL_FILE / $BAUDBOT_SOURCE_BRANCH_FILE directly
• Added regression test coverage in bin/update-release.test.sh

The SKILL.md files were condensed to reduce token usage in agent prompts while preserving all operational guidance.

Confidence Score: 5/5

• This PR is safe to merge with minimal risk
• The fix correctly addresses the metadata path leak by ensuring release paths are normalized after all env/CLI parsing. The logic change is sound: moving path refresh to after argument parsing and removing early cached locals prevents stale environment variables from leaking through. The new regression test validates the fix. Documentation changes are token-reduction refactoring with no behavioral impact.
• No files require special attention

Important Files Changed

Filename	Overview
bin/update-release.sh	Fixed release-root metadata path leak by removing early cached source path locals and normalizing release paths after all CLI/env parsing
bin/update-release.test.sh	Added regression test to verify BAUDBOT_RELEASE_ROOT overrides inherited stale BAUDBOT_SOURCE_* environment variables

_{Last reviewed commit: 7719186}