deploy: fix rollback release-root path contamination

[benvinegar]

Summary

• fix bin/rollback-release.sh to normalize release paths after env/CLI parsing
• ensure BAUDBOT_RELEASE_ROOT wins over inherited BAUDBOT_RELEASES_DIR, BAUDBOT_CURRENT_LINK, and BAUDBOT_PREVIOUS_LINK
• add regression coverage in bin/rollback-release.test.sh for stale rollback path env vars

Validation

• bin/rollback-release.test.sh
• bin/update-release.test.sh
• npm run test:shell

[greptile-apps]

Greptile Summary

Mirrors the fix from PR #130 (update-release.sh) by ensuring BAUDBOT_RELEASE_ROOT always wins over inherited environment variables (BAUDBOT_RELEASES_DIR, BAUDBOT_CURRENT_LINK, BAUDBOT_PREVIOUS_LINK).

• Changed --release-root argument parsing to set BAUDBOT_RELEASE_ROOT directly instead of immediately calling bb_refresh_release_paths
• Added normalization call after all argument parsing completes, ensuring paths are derived from the final BAUDBOT_RELEASE_ROOT value
• Added regression test with stale environment variables to verify the fix prevents path contamination

Confidence Score: 5/5

• This PR is safe to merge with minimal risk
• The change follows the exact same pattern as the previous fix in PR deploy: fix update-release release-root metadata path leak #130 for update-release.sh, includes comprehensive test coverage for the regression case, and the logic is straightforward - deferring path normalization until after all argument parsing ensures BAUDBOT_RELEASE_ROOT properly overrides stale environment variables
• No files require special attention

Important Files Changed

Filename	Overview
bin/rollback-release.sh	Fixed --release-root CLI argument to set BAUDBOT_RELEASE_ROOT directly instead of calling bb_refresh_release_paths immediately, then normalized all release paths after argument parsing to prevent stale environment variable contamination
bin/rollback-release.test.sh	Added test helper run_rollback_with_stale_release_paths and regression test test_rollback_release_root_overrides_stale_release_path_env to verify that BAUDBOT_RELEASE_ROOT correctly overrides stale inherited path environment variables

_{Last reviewed commit: c2d0dc7}