Fix orphaned CI droplets on cancelled runs#28
Merged
Conversation
The cleanup step passes the deterministic droplet name as a fallback. If the droplet ID was never captured (e.g. run cancelled mid-create), destroy now looks up the droplet by name via the baudbot-ci tag. Also tags all CI droplets with baudbot-ci and adds a list command for debugging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
CI droplets leak when a GitHub Actions run is cancelled mid-create. The droplet gets created on DigitalOcean but the ID never makes it to
GITHUB_OUTPUT, so the cleanup step has nothing to destroy.Fix
baudbot-cion creationci-{distro}-{run_id}) to the cleanup step as a third argcmd_destroyfalls back to looking up the droplet by name when no ID is availabledroplet.sh listcommand for debugging orphansStill needed
The 10 existing orphan droplets need to be manually destroyed. Run: