chore: remove dead code and stale benchmarks (#44)

benvinegar · web-flow · commit 6c2b91270f8f · 2026-03-22T13:24:46.000-04:00
* chore: remove dead code and stale benchmarks

* fix: restore npm install smoke fallback
diff --git a/autoresearch.checks.sh b/autoresearch.checks.sh
diff --git a/autoresearch.sh b/autoresearch.sh
diff --git a/bun.lock b/bun.lock
diff --git a/knip.json b/knip.json
@@ -0,0 +1,10 @@
+{
+  "$schema": "https://unpkg.com/knip@latest/schema.json",
+  "project": [
+    "src/**/*.{ts,tsx}",
+    "scripts/**/*.ts",
+    "test/**/*.{ts,tsx}",
+    "bin/**/*.cjs"
+  ],
+  "ignoreDependencies": ["bun"]
+}
diff --git a/package.json b/package.json
@@ -69,7 +69,6 @@
     "bun": "^1.3.10",
     "commander": "^14.0.3",
     "diff": "^8.0.3",
-    "parse-diff": "^0.11.1",
     "react": "^19.2.4",
     "zod": "^4.3.6"
   },
diff --git a/scripts/check-pack.ts b/scripts/check-pack.ts
@@ -52,7 +52,7 @@ for (const path of requiredPaths) {
 }
 
 const forbiddenPrefixes = [".github/", "src/", "test/", "scripts/", "tmp/"];
-const forbiddenPaths = ["AGENTS.md", "autoresearch.checks.sh", "autoresearch.sh", "bun.lock"];
+const forbiddenPaths = ["AGENTS.md", "bun.lock"];
 
 for (const file of pack.files) {
   if (forbiddenPrefixes.some((prefix) => file.path.startsWith(prefix)) || forbiddenPaths.includes(file.path)) {
diff --git a/src/core/config.ts b/src/core/config.ts
@@ -181,5 +181,3 @@ export function resolveConfiguredCliInput(
   };
 }
 
-export const CONFIG_DEFAULTS = DEFAULT_VIEW_PREFERENCES;
-export const CONFIG_SECTION_KEYS = CONFIG_SECTION_NAMES;
diff --git a/src/mcp/client.ts b/src/mcp/client.ts
@@ -15,7 +15,7 @@ const DAEMON_STARTUP_TIMEOUT_MS = 3_000;
 const RECONNECT_DELAY_MS = 3_000;
 const HEARTBEAT_INTERVAL_MS = 10_000;
 
-export interface HunkAppBridge {
+interface HunkAppBridge {
   applyComment: (message: Extract<SessionServerMessage, { command: "comment" }>) => Promise<AppliedCommentResult>;
   navigateToHunk: (message: Extract<SessionServerMessage, { command: "navigate_to_hunk" }>) => Promise<NavigatedSelectionResult>;
 }
diff --git a/src/mcp/config.ts b/src/mcp/config.ts
@@ -1,5 +1,5 @@
-export const DEFAULT_HUNK_MCP_HOST = "127.0.0.1";
-export const DEFAULT_HUNK_MCP_PORT = 47657;
+const DEFAULT_HUNK_MCP_HOST = "127.0.0.1";
+const DEFAULT_HUNK_MCP_PORT = 47657;
 export const HUNK_MCP_PATH = "/mcp";
 export const HUNK_SESSION_SOCKET_PATH = "/session";
 
diff --git a/src/mcp/daemonState.ts b/src/mcp/daemonState.ts
@@ -20,7 +20,7 @@ interface PendingCommand {
   timeout: Timer;
 }
 
-export interface DaemonSessionSocket {
+interface DaemonSessionSocket {
   send(data: string): unknown;
 }
 
diff --git a/src/ui/components/chrome/menu.ts b/src/ui/components/chrome/menu.ts
@@ -19,7 +19,7 @@ export interface MenuSpec {
   label: string;
 }
 
-export const MENU_LABELS: Record<MenuId, string> = {
+const MENU_LABELS: Record<MenuId, string> = {
   file: "File",
   view: "View",
   navigate: "Navigate",
diff --git a/src/ui/lib/agentAnnotations.ts b/src/ui/lib/agentAnnotations.ts
@@ -13,7 +13,7 @@ function overlap(rangeA: [number, number], rangeB: [number, number]) {
 }
 
 /** Compute the old/new line ranges covered by a hunk, including single-line edge cases. */
-export function hunkLineRange(hunk: Hunk) {
+function hunkLineRange(hunk: Hunk) {
   const newEnd = Math.max(hunk.additionStart, hunk.additionStart + Math.max(hunk.additionLines, 1) - 1);
   const oldEnd = Math.max(hunk.deletionStart, hunk.deletionStart + Math.max(hunk.deletionLines, 1) - 1);
 
@@ -24,7 +24,7 @@ export function hunkLineRange(hunk: Hunk) {
 }
 
 /** Check whether an annotation belongs to the visible span of a hunk. */
-export function annotationOverlapsHunk(annotation: AgentAnnotation, hunk: Hunk) {
+function annotationOverlapsHunk(annotation: AgentAnnotation, hunk: Hunk) {
   const hunkRange = hunkLineRange(hunk);
 
   if (annotation.newRange && overlap(annotation.newRange, hunkRange.newRange)) {
diff --git a/src/ui/lib/agentPopover.ts b/src/ui/lib/agentPopover.ts
@@ -50,7 +50,7 @@ export function wrapText(text: string, width: number) {
 }
 
 /** Build the framed agent-popover title shown in the card header. */
-export function agentPopoverTitle(noteIndex: number, noteCount: number) {
+function agentPopoverTitle(noteIndex: number, noteCount: number) {
   return noteCount > 1 ? `AI note ${noteIndex + 1}/${noteCount}` : "AI note";
 }
 
diff --git a/src/ui/lib/responsive.ts b/src/ui/lib/responsive.ts
@@ -2,8 +2,8 @@ import type { LayoutMode } from "../../core/types";
 
 export type ResponsiveViewport = "full" | "medium" | "tight";
 
-export const SPLIT_VIEWPORT_MIN_WIDTH = 160;
-export const FULL_VIEWPORT_MIN_WIDTH = 220;
+const SPLIT_VIEWPORT_MIN_WIDTH = 160;
+const FULL_VIEWPORT_MIN_WIDTH = 220;
 
 export interface ResponsiveLayout {
   viewport: ResponsiveViewport;
@@ -12,7 +12,7 @@ export interface ResponsiveLayout {
 }
 
 /** Bucket terminal widths into the viewport classes the shell layout cares about. */
-export function resolveResponsiveViewport(viewportWidth: number): ResponsiveViewport {
+function resolveResponsiveViewport(viewportWidth: number): ResponsiveViewport {
   if (viewportWidth >= FULL_VIEWPORT_MIN_WIDTH) {
     return "full";
   }
diff --git a/test/app-interactions.test.tsx b/test/app-interactions.test.tsx
@@ -279,7 +279,7 @@ describe("App interactions", () => {
       await flush(setup);
 
       await act(async () => {
-        setup.mockInput.pressKey("F10");
+        await setup.mockInput.pressKey("F10");
       });
       await flush(setup);
 
@@ -389,25 +389,32 @@ describe("App interactions", () => {
       expect(initialFrame).toContain("line01 = 101");
       expect(initialFrame).not.toContain("line08 = 108");
 
-      for (let index = 0; index < 3; index += 1) {
+      let frame = initialFrame;
+      for (let index = 0; index < 12; index += 1) {
         await act(async () => {
           await setup.mockInput.pressArrow("down");
         });
         await flush(setup);
+        frame = setup.captureCharFrame();
+        if (frame.includes("line08 = 108")) {
+          break;
+        }
       }
 
-      let frame = setup.captureCharFrame();
       expect(frame).toContain("line08 = 108");
       expect(frame).not.toContain("line01 = 101");
 
-      for (let index = 0; index < 3; index += 1) {
+      for (let index = 0; index < 12; index += 1) {
         await act(async () => {
           await setup.mockInput.pressArrow("up");
         });
         await flush(setup);
+        frame = setup.captureCharFrame();
+        if (frame.includes("line01 = 101")) {
+          break;
+        }
       }
 
-      frame = setup.captureCharFrame();
       expect(frame).toContain("line01 = 101");
     } finally {
       await act(async () => {
@@ -487,7 +494,7 @@ describe("App interactions", () => {
       await flush(setup);
 
       await act(async () => {
-        setup.mockInput.pressKey("F10");
+        await setup.mockInput.pressKey("F10");
       });
       await flush(setup);
 
diff --git a/test/app-syntax-highlight-startup-benchmark.ts b/test/app-syntax-highlight-startup-benchmark.ts
diff --git a/test/render-scroll-benchmark.tsx b/test/render-scroll-benchmark.tsx
diff --git a/test/syntax-highlight-startup-benchmark.ts b/test/syntax-highlight-startup-benchmark.ts

Original file line number	Diff line number	Diff line change
`@@ -52,7 +52,7 @@ for (const path of requiredPaths) {`
`52`	`52`	`}`
`53`	`53`
`54`	`54`	`const forbiddenPrefixes = [".github/", "src/", "test/", "scripts/", "tmp/"];`
`55`		`-const forbiddenPaths = ["AGENTS.md", "autoresearch.checks.sh", "autoresearch.sh", "bun.lock"];`
	`55`	`+const forbiddenPaths = ["AGENTS.md", "bun.lock"];`
`56`	`56`
`57`	`57`	`for (const file of pack.files) {`
`58`	`58`	`if (forbiddenPrefixes.some((prefix) => file.path.startsWith(prefix)) \|\| forbiddenPaths.includes(file.path)) {`
Original file line number	Diff line number	Diff line change
`@@ -181,5 +181,3 @@ export function resolveConfiguredCliInput(`
`181`	`181`	`};`
`182`	`182`	`}`
`183`	`183`
`184`		`-export const CONFIG_DEFAULTS = DEFAULT_VIEW_PREFERENCES;`
`185`		`-export const CONFIG_SECTION_KEYS = CONFIG_SECTION_NAMES;`
Original file line number	Diff line number	Diff line change
`@@ -15,7 +15,7 @@ const DAEMON_STARTUP_TIMEOUT_MS = 3_000;`
`15`	`15`	`const RECONNECT_DELAY_MS = 3_000;`
`16`	`16`	`const HEARTBEAT_INTERVAL_MS = 10_000;`
`17`	`17`
`18`		`-export interface HunkAppBridge {`
	`18`	`+interface HunkAppBridge {`
`19`	`19`	`applyComment: (message: Extract<SessionServerMessage, { command: "comment" }>) => Promise<AppliedCommentResult>;`
`20`	`20`	`navigateToHunk: (message: Extract<SessionServerMessage, { command: "navigate_to_hunk" }>) => Promise<NavigatedSelectionResult>;`
`21`	`21`	`}`
Original file line number	Diff line number	Diff line change
`@@ -20,7 +20,7 @@ interface PendingCommand {`
`20`	`20`	`timeout: Timer;`
`21`	`21`	`}`
`22`	`22`
`23`		`-export interface DaemonSessionSocket {`
	`23`	`+interface DaemonSessionSocket {`
`24`	`24`	`send(data: string): unknown;`
`25`	`25`	`}`
`26`	`26`