Skip to content

fix(release): ignore staged npm artifact when archiving#325

Merged
benvinegar merged 1 commit into
mainfrom
fix/release-asset-archive-filter
May 17, 2026
Merged

fix(release): ignore staged npm artifact when archiving#325
benvinegar merged 1 commit into
mainfrom
fix/release-asset-archive-filter

Conversation

@benvinegar
Copy link
Copy Markdown
Member

Summary

  • limit the GitHub release job download to hunkdiff-* platform artifacts
  • filter the archive loop to platform artifact directories so staged npm release artifacts are ignored

Why

The 0.13.0-beta.0 release workflow downloaded staged-prebuilt-npm-release alongside binary artifacts and tried to archive it as if it contained a top-level hunk binary.

Tests

  • git diff --check
  • local shell simulation with an extra staged-prebuilt-npm-release directory

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented May 17, 2026

Greptile Summary

This PR fixes a bug where the create-github-release job was downloading the staged-prebuilt-npm-release artifact alongside binary platform artifacts and then failing when the archive loop tried to find a hunk binary inside it.

  • Adds pattern: hunkdiff-* to the download-artifact step in create-github-release so only platform binaries are fetched.
  • Adds -name 'hunkdiff-*' to the find command in the archive loop as a second layer of defense, ensuring any non-platform directory that might appear under dist/release/artifacts is skipped.

Confidence Score: 5/5

Safe to merge — two minimal, consistent guards fix the artifact-contamination bug without touching any other job or logic.

The download pattern and the find filter both target the same well-defined artifact naming convention (hunkdiff-*). The stage-release job intentionally retains its unfiltered download, and the create-github-release job now correctly ignores the npm staging artifact at both the fetch and archive stages. No unintended side effects are visible.

No files require special attention.

Important Files Changed

Filename Overview
.github/workflows/release-prebuilt-npm.yml Two targeted guards added to the create-github-release job: a download pattern filter and a find name filter. Both changes are correct and consistent with the artifact naming convention.

Reviews (1): Last reviewed commit: "fix(release): ignore staged npm artifact..." | Re-trigger Greptile

@benvinegar
Copy link
Copy Markdown
Member Author

Note: the Windows compatibility check failed before any project commands ran, during oven-sh/setup-bun immediately after a Bun cache hit. It appears unrelated to this workflow-only release artifact filter change. I’ll rerun it once the workflow finishes.

@benvinegar
Copy link
Copy Markdown
Member Author

CI failures look unrelated/flaky:

  • Windows compatibility failed in oven-sh/setup-bun before any project commands ran.
  • Linux Typecheck + Test + Smoke failed in one PTY integration assertion (explicit split mode stays split after a live resize) where the terminal capture was truncated; this is unrelated to the release workflow YAML change.

I reran the failed jobs.

@benvinegar benvinegar merged commit 9b01f12 into main May 17, 2026
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant