fix(ui): honor custom comment colors#558
Draft
arbiter-hd wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
[custom_theme.syntax].commentfor Pierre-highlighted diffs.hunkdiff.Root cause
Pierre emits TypeScript comments as
#737373, but Hunk's reserved token-color map did not associate that color with thecommentsyntax role. The raw Pierre color therefore bypassed the configured custom comment color.The renderer currently remaps by raw color, so other Pierre scopes that share
#737373will also inheritsyntax.comment.Fixes #557.
Validation
bun test src/ui/diff/pierre.test.ts(16 passed)bun run typecheckbun run lintbun run format:checkbun run test:theme-contrastbun run test:integration(55 passed)bun run test:tty-smokebun run changeset:status -- --since=upstream/mainFull
bun test: 1206 passed, 22 skipped, and one unrelatedAppHost.watch.test.tsxfailure that reproduces unchanged onupstream/mainat2458366.