Skip to content

Commit 0d3f25a

Browse files
bashmishbashmish
committed
test: ensure strict equality check
1 parent 940e895 commit 0d3f25a

6 files changed

Lines changed: 124 additions & 52 deletions

File tree

‎packages/dev-server-esbuild/test/browser-targets.test.ts‎

Lines changed: 38 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -8,70 +8,94 @@ const { browsers } = bcd;
88
describe('isLatestModernBrowser', () => {
99
it('returns true for latest Chrome', async () => {
1010
const latest = getLatestStableMajor(browsers.chrome.releases)!;
11-
assert.equal(isLatestModernBrowser({ name: 'Chrome', version: String(latest) }), true);
11+
assert.strictEqual(isLatestModernBrowser({ name: 'Chrome', version: String(latest) }), true);
1212
});
1313

1414
it('returns true for latest Chrome -1', async () => {
1515
const latest = getLatestStableMajor(browsers.chrome.releases)!;
16-
assert.equal(isLatestModernBrowser({ name: 'Chrome', version: String(latest - 1) }), true);
16+
assert.strictEqual(
17+
isLatestModernBrowser({ name: 'Chrome', version: String(latest - 1) }),
18+
true,
19+
);
1720
});
1821

1922
it('returns true for future version of Chrome', async () => {
2023
const latest = getLatestStableMajor(browsers.chrome.releases)!;
21-
assert.equal(isLatestModernBrowser({ name: 'Chrome', version: String(latest + 1) }), true);
24+
assert.strictEqual(
25+
isLatestModernBrowser({ name: 'Chrome', version: String(latest + 1) }),
26+
true,
27+
);
2228
});
2329

2430
it('returns true for unknown version of Chrome', async () => {
25-
assert.equal(isLatestModernBrowser({ name: 'Chrome', version: '9999999' }), true);
31+
assert.strictEqual(isLatestModernBrowser({ name: 'Chrome', version: '9999999' }), true);
2632
});
2733

2834
it('returns false for latest Chrome -2', async () => {
2935
const latest = getLatestStableMajor(browsers.chrome.releases)!;
30-
assert.equal(isLatestModernBrowser({ name: 'Chrome', version: String(latest - 2) }), false);
36+
assert.strictEqual(
37+
isLatestModernBrowser({ name: 'Chrome', version: String(latest - 2) }),
38+
false,
39+
);
3140
});
3241

3342
it('returns false for latest Chrome -3', async () => {
3443
const latest = getLatestStableMajor(browsers.chrome.releases)!;
35-
assert.equal(isLatestModernBrowser({ name: 'Chrome', version: String(latest - 3) }), false);
44+
assert.strictEqual(
45+
isLatestModernBrowser({ name: 'Chrome', version: String(latest - 3) }),
46+
false,
47+
);
3648
});
3749

3850
it('returns true for latest Chrome Headless', async () => {
3951
const latest = getLatestStableMajor(browsers.chrome.releases)!;
40-
assert.equal(isLatestModernBrowser({ name: 'Chrome Headless', version: String(latest) }), true);
52+
assert.strictEqual(
53+
isLatestModernBrowser({ name: 'Chrome Headless', version: String(latest) }),
54+
true,
55+
);
4156
});
4257

4358
it('returns true for latest chromium', async () => {
4459
const latest = getLatestStableMajor(browsers.chrome.releases)!;
45-
assert.equal(isLatestModernBrowser({ name: 'Chromium', version: String(latest) }), true);
60+
assert.strictEqual(isLatestModernBrowser({ name: 'Chromium', version: String(latest) }), true);
4661
});
4762

4863
it('returns true for latest Firefox', async () => {
4964
const latest = getLatestStableMajor(browsers.firefox.releases)!;
50-
assert.equal(isLatestModernBrowser({ name: 'Firefox', version: String(latest) }), true);
65+
assert.strictEqual(isLatestModernBrowser({ name: 'Firefox', version: String(latest) }), true);
5166
});
5267

5368
it('returns false for latest Firefox -1', async () => {
5469
const latest = getLatestStableMajor(browsers.firefox.releases)!;
55-
assert.equal(isLatestModernBrowser({ name: 'Firefox', version: String(latest - 1) }), false);
70+
assert.strictEqual(
71+
isLatestModernBrowser({ name: 'Firefox', version: String(latest - 1) }),
72+
false,
73+
);
5674
});
5775

5876
it('returns false for latest Firefox -2', async () => {
5977
const latest = getLatestStableMajor(browsers.firefox.releases)!;
60-
assert.equal(isLatestModernBrowser({ name: 'Firefox', version: String(latest - 2) }), false);
78+
assert.strictEqual(
79+
isLatestModernBrowser({ name: 'Firefox', version: String(latest - 2) }),
80+
false,
81+
);
6182
});
6283

6384
it('returns true for latest Edge', async () => {
6485
const latest = getLatestStableMajor(browsers.edge.releases)!;
65-
assert.equal(isLatestModernBrowser({ name: 'Edge', version: String(latest) }), true);
86+
assert.strictEqual(isLatestModernBrowser({ name: 'Edge', version: String(latest) }), true);
6687
});
6788

6889
it('returns true for latest Edge -1', async () => {
6990
const latest = getLatestStableMajor(browsers.edge.releases)!;
70-
assert.equal(isLatestModernBrowser({ name: 'Edge', version: String(latest - 1) }), true);
91+
assert.strictEqual(isLatestModernBrowser({ name: 'Edge', version: String(latest - 1) }), true);
7192
});
7293

7394
it('returns false for latest Edge -2', async () => {
7495
const latest = getLatestStableMajor(browsers.edge.releases)!;
75-
assert.equal(isLatestModernBrowser({ name: 'Chrome', version: String(latest - 2) }), false);
96+
assert.strictEqual(
97+
isLatestModernBrowser({ name: 'Chrome', version: String(latest - 2) }),
98+
false,
99+
);
76100
});
77101
});

‎packages/dev-server-esbuild/test/json.test.ts‎

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,11 @@ describe('esbuildPlugin JSON', () => {
2525
const response = await fetch(`${host}/foo.json`);
2626
const text = await response.text();
2727

28-
assert.equal(response.status, 200);
29-
assert.equal(response.headers.get('content-type'), 'application/javascript; charset=utf-8');
28+
assert.strictEqual(response.status, 200);
29+
assert.strictEqual(
30+
response.headers.get('content-type'),
31+
'application/javascript; charset=utf-8',
32+
);
3033
expectIncludes(text, 'var foo = "bar";');
3134
expectIncludes(text, 'var foo_default = { foo };');
3235
expectIncludes(text, 'export {');

‎packages/dev-server-esbuild/test/jsx.test.ts‎

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,11 @@ export function foo(bar) {
2929
const response = await fetch(`${host}/foo.jsx`);
3030
const text = await response.text();
3131

32-
assert.equal(response.status, 200);
33-
assert.equal(response.headers.get('content-type'), 'application/javascript; charset=utf-8');
32+
assert.strictEqual(response.status, 200);
33+
assert.strictEqual(
34+
response.headers.get('content-type'),
35+
'application/javascript; charset=utf-8',
36+
);
3437
expectIncludes(text, 'React.createElement("div", {');
3538
expectIncludes(text, 'id: "myDiv"');
3639
expectIncludes(text, 'React.createElement(MyElement, {');
@@ -64,8 +67,11 @@ export function foo(bar) {
6467
const response = await fetch(`${host}/foo.jsx`);
6568
const text = await response.text();
6669

67-
assert.equal(response.status, 200);
68-
assert.equal(response.headers.get('content-type'), 'application/javascript; charset=utf-8');
70+
assert.strictEqual(response.status, 200);
71+
assert.strictEqual(
72+
response.headers.get('content-type'),
73+
'application/javascript; charset=utf-8',
74+
);
6975
expectIncludes(text, 'h("div", {');
7076
expectIncludes(text, 'id: "myDiv"');
7177
expectIncludes(text, 'h(MyElement, {');

‎packages/dev-server-esbuild/test/target.test.ts‎

Lines changed: 34 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -80,8 +80,11 @@ describe('esbuildPlugin target', () => {
8080
const response = await fetch(`${host}/foo.js`);
8181
const text = await response.text();
8282

83-
assert.equal(response.status, 200);
84-
assert.equal(response.headers.get('content-type'), 'application/javascript; charset=utf-8');
83+
assert.strictEqual(response.status, 200);
84+
assert.strictEqual(
85+
response.headers.get('content-type'),
86+
'application/javascript; charset=utf-8',
87+
);
8588

8689
expectIncludes(text, syntax.classes);
8790
for (const e of syntax.classFields) {
@@ -120,8 +123,11 @@ describe('esbuildPlugin target', () => {
120123
const response = await fetch(`${host}/foo.js`);
121124
const text = await response.text();
122125

123-
assert.equal(response.status, 200);
124-
assert.equal(response.headers.get('content-type'), 'application/javascript; charset=utf-8');
126+
assert.strictEqual(response.status, 200);
127+
assert.strictEqual(
128+
response.headers.get('content-type'),
129+
'application/javascript; charset=utf-8',
130+
);
125131

126132
expectIncludes(text, syntax.classes);
127133
for (const e of transformedSyntax.classFields) {
@@ -160,8 +166,11 @@ describe('esbuildPlugin target', () => {
160166
const response = await fetch(`${host}/foo.js`);
161167
const text = await response.text();
162168

163-
assert.equal(response.status, 200);
164-
assert.equal(response.headers.get('content-type'), 'application/javascript; charset=utf-8');
169+
assert.strictEqual(response.status, 200);
170+
assert.strictEqual(
171+
response.headers.get('content-type'),
172+
'application/javascript; charset=utf-8',
173+
);
165174

166175
expectIncludes(text, syntax.classes);
167176
for (const e of transformedSyntax.classFields) {
@@ -200,8 +209,11 @@ describe('esbuildPlugin target', () => {
200209
const response = await fetch(`${host}/foo.js`);
201210
const text = await response.text();
202211

203-
assert.equal(response.status, 200);
204-
assert.equal(response.headers.get('content-type'), 'application/javascript; charset=utf-8');
212+
assert.strictEqual(response.status, 200);
213+
assert.strictEqual(
214+
response.headers.get('content-type'),
215+
'application/javascript; charset=utf-8',
216+
);
205217

206218
expectIncludes(text, syntax.classes);
207219
for (const e of transformedSyntax.classFields) {
@@ -240,8 +252,11 @@ describe('esbuildPlugin target', () => {
240252
const response = await fetch(`${host}/foo.js`);
241253
const text = await response.text();
242254

243-
assert.equal(response.status, 200);
244-
assert.equal(response.headers.get('content-type'), 'application/javascript; charset=utf-8');
255+
assert.strictEqual(response.status, 200);
256+
assert.strictEqual(
257+
response.headers.get('content-type'),
258+
'application/javascript; charset=utf-8',
259+
);
245260

246261
expectIncludes(text, syntax.classes);
247262
for (const e of transformedSyntax.classFields) {
@@ -278,8 +293,11 @@ describe('esbuildPlugin target', () => {
278293
const response = await fetch(`${host}/foo.js`);
279294
const text = await response.text();
280295

281-
assert.equal(response.status, 200);
282-
assert.equal(response.headers.get('content-type'), 'application/javascript; charset=utf-8');
296+
assert.strictEqual(response.status, 200);
297+
assert.strictEqual(
298+
response.headers.get('content-type'),
299+
'application/javascript; charset=utf-8',
300+
);
283301

284302
expectIncludes(text, syntax.classes);
285303
for (const e of transformedSyntax.classFields) {
@@ -320,8 +338,8 @@ describe('esbuildPlugin target', () => {
320338
const response = await fetch(`${host}/index.html`);
321339
const text = await response.text();
322340

323-
assert.equal(response.status, 200);
324-
assert.equal(response.headers.get('content-type'), 'text/html; charset=utf-8');
341+
assert.strictEqual(response.status, 200);
342+
assert.strictEqual(response.headers.get('content-type'), 'text/html; charset=utf-8');
325343

326344
expectIncludes(text, syntax.classes);
327345
for (const e of transformedSyntax.classFields) {
@@ -365,8 +383,8 @@ describe('esbuildPlugin target', () => {
365383
const response = await fetch(`${host}/index.html`);
366384
const text = await response.text();
367385

368-
assert.equal(response.status, 200);
369-
assert.equal(response.headers.get('content-type'), 'text/html; charset=utf-8');
386+
assert.strictEqual(response.status, 200);
387+
assert.strictEqual(response.headers.get('content-type'), 'text/html; charset=utf-8');
370388
expectIncludes(text, importmapString);
371389
expectIncludes(text, jsonString);
372390
} finally {

‎packages/dev-server-esbuild/test/ts.test.ts‎

Lines changed: 27 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -38,8 +38,11 @@ describe('esbuildPlugin TS', { timeout: 5000 }, () => {
3838
try {
3939
const response = await fetch(`${host}/foo.ts`);
4040
const text = await response.text();
41-
assert.equal(response.status, 200);
42-
assert.equal(response.headers.get('content-type'), 'application/javascript; charset=utf-8');
41+
assert.strictEqual(response.status, 200);
42+
assert.strictEqual(
43+
response.headers.get('content-type'),
44+
'application/javascript; charset=utf-8',
45+
);
4346
expectIncludes(text, 'export function foo(a, b) {');
4447
expectIncludes(text, 'return a + b;');
4548
expectIncludes(text, '}');
@@ -82,8 +85,11 @@ class Bar {
8285
const response = await fetch(`${host}/foo.ts`);
8386
const text = await response.text();
8487

85-
assert.equal(response.status, 200);
86-
assert.equal(response.headers.get('content-type'), 'application/javascript; charset=utf-8');
88+
assert.strictEqual(response.status, 200);
89+
assert.strictEqual(
90+
response.headers.get('content-type'),
91+
'application/javascript; charset=utf-8',
92+
);
8793
expectIncludes(text, '__decorate');
8894
expectIncludes(text, '__publicField(this, "x", "y");');
8995
expectIncludes(
@@ -118,8 +124,11 @@ class Bar {
118124
const response = await fetch(`${host}/a/b/foo.ts`);
119125
const text = await response.text();
120126

121-
assert.equal(response.status, 200);
122-
assert.equal(response.headers.get('content-type'), 'application/javascript; charset=utf-8');
127+
assert.strictEqual(response.status, 200);
128+
assert.strictEqual(
129+
response.headers.get('content-type'),
130+
'application/javascript; charset=utf-8',
131+
);
123132
expectIncludes(text, 'import "../../x.ts";');
124133
expectIncludes(text, 'import "../y.ts";');
125134
expectIncludes(text, 'import "./z.ts";');
@@ -143,8 +152,11 @@ class Bar {
143152
const response = await fetch(`${host}/a/b/foo.ts`);
144153
const text = await response.text();
145154

146-
assert.equal(response.status, 200);
147-
assert.equal(response.headers.get('content-type'), 'application/javascript; charset=utf-8');
155+
assert.strictEqual(response.status, 200);
156+
assert.strictEqual(
157+
response.headers.get('content-type'),
158+
'application/javascript; charset=utf-8',
159+
);
148160
expectIncludes(text, 'import "../../1.js";');
149161
expectIncludes(text, 'import "../2.js";');
150162
expectIncludes(text, 'import "./3.js";');
@@ -172,7 +184,7 @@ class Bar {
172184
const response = await fetch(`${host}/a/b/foo.ts`);
173185
const text = await response.text();
174186

175-
assert.equal(response.status, 200);
187+
assert.strictEqual(response.status, 200);
176188
expectIncludes(text, "import '../../x.js';");
177189
expectIncludes(text, "import '../y.js';");
178190
expectIncludes(text, "import './z.js';");
@@ -196,7 +208,7 @@ class Bar {
196208
const response = await fetch(`${host}/a/b/bar.js`);
197209
const text = await response.text();
198210

199-
assert.equal(response.status, 200);
211+
assert.strictEqual(response.status, 200);
200212
expectIncludes(text, "import '../../x.js';");
201213
expectIncludes(text, "import '../y.js';");
202214
expectIncludes(text, "import './z.js';");
@@ -259,8 +271,11 @@ class Bar {
259271
const response = await fetch(`${host}/a/b/foo.ts`);
260272
const text = await response.text();
261273

262-
assert.equal(response.status, 200);
263-
assert.equal(response.headers.get('content-type'), 'application/javascript; charset=utf-8');
274+
assert.strictEqual(response.status, 200);
275+
assert.strictEqual(
276+
response.headers.get('content-type'),
277+
'application/javascript; charset=utf-8',
278+
);
264279

265280
expectIncludes(text, '__publicField(this, "prop");');
266281
} finally {

‎packages/dev-server-esbuild/test/tsx.test.ts‎

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -36,8 +36,11 @@ export function foo (a: number, b: number): Foo {
3636
const response = await fetch(`${host}/foo.tsx`);
3737
const text = await response.text();
3838

39-
assert.equal(response.status, 200);
40-
assert.equal(response.headers.get('content-type'), 'application/javascript; charset=utf-8');
39+
assert.strictEqual(response.status, 200);
40+
assert.strictEqual(
41+
response.headers.get('content-type'),
42+
'application/javascript; charset=utf-8',
43+
);
4144
expectIncludes(text, 'React.createElement("div", {');
4245
expectIncludes(text, 'id: "myDiv"');
4346
expectIncludes(text, 'React.createElement(MyElement, {');
@@ -80,8 +83,11 @@ export function foo (a: number, b: number): Foo {
8083
const response = await fetch(`${host}/foo.tsx`);
8184
const text = await response.text();
8285

83-
assert.equal(response.status, 200);
84-
assert.equal(response.headers.get('content-type'), 'application/javascript; charset=utf-8');
86+
assert.strictEqual(response.status, 200);
87+
assert.strictEqual(
88+
response.headers.get('content-type'),
89+
'application/javascript; charset=utf-8',
90+
);
8591
expectIncludes(text, 'h("div", {');
8692
expectIncludes(text, 'id: "myDiv"');
8793
expectIncludes(text, 'h(MyElement, {');

0 commit comments

Comments
 (0)