Skip to content

Commit 1be7ef1

Browse files
committed
fix: restore test files to master, fix lint, add react-dom devDep
- Restore ALL test files to master versions with only .ts import rewrites (removes leaked node:test/node:assert imports from PR2) - Replace @typescript-eslint/ban-types with no-empty-object-type in inline disable comments (ban-types removed in v8) - Fix invalid typeof comparison in rollupAdapter.ts - Add eslintConfig.root: true to prevent parent config interference - Add react-dom devDependency for storybook builder tests - Regenerate package-lock.json from master base Assisted-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent 8076c1c commit 1be7ef1

61 files changed

Lines changed: 10439 additions & 945 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

package-lock.json

Lines changed: 7795 additions & 671 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,8 @@
7272
"mocha": "^10.8.2",
7373
"nanocolors": "^0.2.1",
7474
"prettier": "^3.7.1",
75+
"react": "^19.0.0",
76+
"react-dom": "^19.0.0",
7577
"prettier-plugin-package": "^2.0.0",
7678
"rimraf": "^4.4.1",
7779
"rollup": "^4.4.0",
@@ -82,6 +84,7 @@
8284
"@types/ws": "^8.5.13"
8385
},
8486
"eslintConfig": {
87+
"root": true,
8588
"parser": "@typescript-eslint/parser",
8689
"plugins": [
8790
"@typescript-eslint"

packages/browser-logs/src/serialize.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
var KEY_WTR_TYPE = '__WTR_TYPE__';
33
var KEY_CONSTRUCTOR_NAME = '__WTR_CONSTRUCTOR_NAME__';
44

5-
/* eslint-disable @typescript-eslint/ban-types */
5+
/* eslint-disable @typescript-eslint/no-empty-object-type */
66
function catchFallback<T>(fn: (...args: any[]) => T, fallback = null) {
77
try {
88
return fn();

packages/dev-server-core/test/helpers.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import {
66
expectIncludes,
77
virtualFilesPlugin,
88
} from '../src/test-helpers.js';
9-
import { DevServerCoreConfig } from '../src/server/DevServerCoreConfig.js';
9+
import { DevServerCoreConfig } from '../src/server/DevServerCoreConfig.ts';
1010

1111
export function createTestServer(config: Partial<DevServerCoreConfig> = {}) {
1212
return originalCreateTestServer({

packages/dev-server-core/test/middleware/historyApiFallbackMiddleware.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
import { expect } from 'chai';
22
import path from 'path';
33

4-
import { createTestServer } from '../helpers.js';
5-
import { DevServer } from '../../src/server/DevServer.js';
4+
import { createTestServer } from '../helpers.ts';
5+
import { DevServer } from '../../src/server/DevServer.ts';
66

77
describe('history api fallback middleware', () => {
88
describe('index in root', () => {

packages/dev-server-core/test/middleware/serveFilesMiddleware.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import { expect } from 'chai';
22
import path from 'path';
33

4-
import { createTestServer } from '../helpers.js';
4+
import { createTestServer } from '../helpers.ts';
55

66
describe('serveFilesMiddleware', () => {
77
it('can serve files outside of the root directory', async () => {

packages/dev-server-core/test/plugins/mimeTypesPlugin.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import { expect } from 'chai';
22

3-
import { createTestServer } from '../helpers.js';
3+
import { createTestServer } from '../helpers.ts';
44

55
describe('mimeTypesPLugin', () => {
66
it('can configure mime types for files', async () => {

packages/dev-server-core/test/plugins/parseDynamicImport.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { expect } from 'chai';
2-
import { parseDynamicImport } from '../../src/plugins/parseDynamicImport.js';
2+
import { parseDynamicImport } from '../../src/plugins/parseDynamicImport.ts';
33

44
describe('parseDynamicImport', () => {
55
function testParseDynamicImport(specifier: string) {

packages/dev-server-esbuild/test/banner-footer.test.ts

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,8 @@
1-
import assert from 'node:assert/strict';
2-
import { describe, it } from 'node:test';
3-
import path from 'path';
4-
import { createTestServer } from '@web/dev-server-core/test-helpers.js';
5-
import { expectIncludes } from '@web/dev-server-core/test-helpers.js';
1+
import { expect } from 'chai';
2+
import { createTestServer } from '@web/dev-server-core/test-helpers';
3+
import { expectIncludes } from '@web/dev-server-core/test-helpers';
64

7-
import { esbuildPlugin } from '../src/index.js';
5+
import { esbuildPlugin } from '../src/index.ts';
86

97
describe('esbuildPlugin banner/footers', function () {
108
this.timeout(5000);

packages/dev-server-esbuild/test/browser-targets.test.ts

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
1-
import assert from 'node:assert/strict';
2-
import { describe, it } from 'node:test';
3-
import browserCompatData from '@mdn/browser-compat-data.ts';
4-
const { browsers } = browserCompatData;
1+
import { expect } from 'chai';
2+
import { browsers } from '@mdn/browser-compat-data';
53
import { isLatestModernBrowser, getLatestStableMajor } from '../src/browser-targets.ts';
64

75
describe('isLatestModernBrowser', () => {

0 commit comments

Comments
 (0)