Skip to content

Commit 44b178f

Browse files
authored
fix: update puppeteer to v25 (#3135)
* fix: update puppeteer to v25 * fix: replace removed isConnected() with a new prop * fix: prevent bfcache from caching test page with open WS connection
1 parent a7972ab commit 44b178f

9 files changed

Lines changed: 885 additions & 730 deletions

File tree

.changeset/silly-years-rescue.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
---
2+
'@web/dev-server-core': patch
3+
'@web/test-runner-puppeteer': patch
4+
'@web/test-runner-chrome': patch
5+
---
6+
7+
update puppeteer to v25

package-lock.json

Lines changed: 868 additions & 721 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/browser-logs/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,6 @@
5050
"errorstacks": "^2.4.1"
5151
},
5252
"devDependencies": {
53-
"puppeteer": "^24.0.0"
53+
"puppeteer": "^25.0.0"
5454
}
5555
}

packages/dev-server-core/src/web-sockets/webSocketsPlugin.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -127,6 +127,7 @@ export function webSocketsPlugin(): Plugin {
127127
}
128128
}
129129
130+
window.addEventListener('unload', () => {});
130131
131132
const { protocol, host } = new URL(import.meta.url);
132133
const webSocketUrl = \`ws\${protocol === 'https:' ? 's' : ''}://\${host}/${NAME_WEB_SOCKET_API}\`;

packages/dev-server-hmr/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,6 @@
4444
},
4545
"devDependencies": {
4646
"lit-html": "^2.7.3 || ^3.0.0",
47-
"puppeteer": "^24.0.0"
47+
"puppeteer": "^25.0.0"
4848
}
4949
}

packages/dev-server/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,6 @@
7373
"devDependencies": {
7474
"@types/command-line-usage": "^5.0.1",
7575
"lit-html": "^2.7.3 || ^3.0.0",
76-
"puppeteer": "^24.0.0"
76+
"puppeteer": "^25.0.0"
7777
}
7878
}

packages/test-runner-chrome/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@
4949
"@web/test-runner-core": "^1.0.0",
5050
"@web/test-runner-coverage-v8": "^1.0.0",
5151
"chrome-launcher": "^0.15.0",
52-
"puppeteer-core": "^24.0.0"
52+
"puppeteer-core": "^25.0.0"
5353
},
5454
"devDependencies": {
5555
"@types/istanbul-reports": "^3.0.0",

packages/test-runner-chrome/src/ChromeLauncher.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -123,10 +123,10 @@ export class ChromeLauncher implements BrowserLauncher {
123123
}
124124

125125
async stop() {
126-
if (this.browser?.isConnected()) {
126+
if (this.browser?.connected) {
127127
await this.browser.close();
128128
}
129-
if (this.debugBrowser?.isConnected()) {
129+
if (this.debugBrowser?.connected) {
130130
await this.debugBrowser.close();
131131
}
132132
}
@@ -210,7 +210,7 @@ export class ChromeLauncher implements BrowserLauncher {
210210
return this.__startBrowserPromise;
211211
}
212212

213-
if (!this.browser || !this.browser?.isConnected() || !this.browserContext) {
213+
if (!this.browser || !this.browser?.connected || !this.browserContext) {
214214
this.__startBrowserPromise = this.startBrowser();
215215
const { browser, context } = await this.__startBrowserPromise;
216216
this.browser = browser;

packages/test-runner-puppeteer/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,10 +48,10 @@
4848
"dependencies": {
4949
"@web/test-runner-chrome": "^1.0.0",
5050
"@web/test-runner-core": "^1.0.0",
51-
"puppeteer": "^24.0.0"
51+
"puppeteer": "^25.0.0"
5252
},
5353
"devDependencies": {
5454
"@web/test-runner-mocha": "^1.0.0",
55-
"puppeteer-core": "^24.0.0"
55+
"puppeteer-core": "^25.0.0"
5656
}
5757
}

0 commit comments

Comments
 (0)