Skip to content

Commit 69de815

Browse files
committed
fix: restore parse5 v6 deps and fix ws/koa type resolution
- Restore parse5 to ^6.0.1 in all packages (v8 migration is in PR4) - Keep koa v3 / ws v8 in dev-server-core (required for nodenext compat) - Use WebSocketServer from ws v8 API - Remove nested @types cleanup for ws (not needed) Assisted-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent e2af495 commit 69de815

11 files changed

Lines changed: 68 additions & 44 deletions

File tree

package-lock.json

Lines changed: 56 additions & 32 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
"node": ">=18.0.0"
1111
},
1212
"scripts": {
13-
"build": "node scripts/fix-jridgewell-dcts.js && rm -rf packages/dev-server-core/node_modules/@types/koa packages/dev-server-core/node_modules/@types/ws packages/dev-server-core/node_modules/ws && npm run build:clean && tsc --build",
13+
"build": "node scripts/fix-jridgewell-dcts.js && rm -rf packages/dev-server-core/node_modules/@types/koa packages/dev-server-core/node_modules/@types/ws && npm run build:clean && tsc --build",
1414
"build:clean": "rimraf --glob packages/*/tsconfig.tsbuildinfo && rimraf --glob packages/*/dist",
1515
"build:production": "node scripts/workspaces-scripts-bin.mjs build:production",
1616
"build:site": "npm run build && rocket build",

packages/dev-server-core/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@
7171
"koa-static": "^5.0.0",
7272
"lru-cache": "^8.0.4",
7373
"mime-types": "^2.1.27",
74-
"parse5": "^7.0.0 || ^8.0.0",
74+
"parse5": "^6.0.1",
7575
"picomatch": "^2.2.2",
7676
"ws": "^8.18.3"
7777
},

packages/dev-server-core/src/web-sockets/WebSocketsManager.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import type { Server } from 'net';
2-
import WebSocket from 'ws';
2+
import WebSocket, { WebSocketServer } from 'ws';
33
import { EventEmitter } from './EventEmitter.ts';
44

55
export const NAME_WEB_SOCKET_IMPORT = '/__web-dev-server__web-socket.js';
@@ -17,13 +17,13 @@ export interface Events {
1717
*/
1818
export class WebSocketsManager extends EventEmitter<Events> {
1919
public webSocketImport = NAME_WEB_SOCKET_IMPORT;
20-
public webSocketServer: WebSocket.Server;
20+
public webSocketServer: WebSocketServer;
2121
private openSockets = new Set<WebSocket>();
2222

2323
constructor(server: Server) {
2424
super();
2525

26-
this.webSocketServer = new WebSocket.Server({
26+
this.webSocketServer = new WebSocketServer({
2727
noServer: true,
2828
path: `/${NAME_WEB_SOCKET_API}`,
2929
});

packages/dev-server-esbuild/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@
5353
"@mdn/browser-compat-data": "^4.0.0",
5454
"@web/dev-server-core": "^0.7.4",
5555
"esbuild": "^0.25.0",
56-
"parse5": "^7.0.0 || ^8.0.0",
56+
"parse5": "^6.0.1",
5757
"ua-parser-js": "^1.0.33"
5858
},
5959
"devDependencies": {

packages/dev-server-import-maps/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@
5252
"@import-maps/resolve": "^1.0.1",
5353
"@web/dev-server-core": "^0.7.2",
5454
"@web/parse5-utils": "^2.1.0",
55-
"parse5": "^7.0.0 || ^8.0.0",
55+
"parse5": "^6.0.1",
5656
"picomatch": "^2.2.2"
5757
},
5858
"devDependencies": {

packages/dev-server-legacy/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@
6363
"browserslist": "^4.16.0",
6464
"browserslist-useragent": "^4.0.0",
6565
"caniuse-api": "^3.0.0",
66-
"parse5": "^7.0.0 || ^8.0.0",
66+
"parse5": "^6.0.1",
6767
"valid-url": "^1.0.9"
6868
},
6969
"devDependencies": {

packages/dev-server-rollup/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@
5050
"@rollup/plugin-node-resolve": "^15.0.1",
5151
"@web/dev-server-core": "^0.7.2",
5252
"nanocolors": "^0.2.13",
53-
"parse5": "^7.0.0 || ^8.0.0",
53+
"parse5": "^6.0.1",
5454
"rollup": "^4.4.0",
5555
"whatwg-url": "^14.0.0"
5656
},

packages/parse5-utils/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@
4040
"utils"
4141
],
4242
"dependencies": {
43-
"parse5": "^7.0.0 || ^8.0.0"
43+
"parse5": "^6.0.1"
4444
},
4545
"devDependencies": {
4646
"@types/html-minifier-terser": "^7.0.0"

packages/polyfills-loader/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@
5656
"dynamic-import-polyfill": "^0.1.1",
5757
"es-module-shims": "^1.4.1",
5858
"intersection-observer": "^0.12.0",
59-
"parse5": "^7.0.0 || ^8.0.0",
59+
"parse5": "^6.0.1",
6060
"regenerator-runtime": "^0.14.0",
6161
"resize-observer-polyfill": "^1.5.1",
6262
"shady-css-scoped-element": "^0.0.2",

0 commit comments

Comments
 (0)