Skip to content

Commit 70f5530

Browse files
committed
fix: require Node 24 in CI workflows
mocha + ts-node/register is incompatible with module:nodenext on Node 18-22 (.ts file extension not recognized). Update all CI workflows to use Node 24 which natively supports TypeScript. Remove TS_NODE_ env var overrides from test scripts since they're no longer needed on Node 24. Assisted-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent 511c326 commit 70f5530

27 files changed

Lines changed: 56 additions & 59 deletions

File tree

.github/workflows/lint.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ jobs:
1919
env:
2020
FORCE_COLOR: 0
2121
with:
22-
node-version: 20
22+
node-version: 24
2323
cache: npm
2424

2525
- name: Install Dependencies

.github/workflows/verify-browser.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,12 +19,12 @@ jobs:
1919
- name: Workaround for Chrome sandbox issue in Ubuntu 24.04
2020
run: sudo sysctl -w kernel.apparmor_restrict_unprivileged_userns=0
2121

22-
- name: Setup Node 20
22+
- name: Setup Node 24
2323
uses: actions/setup-node@v4
2424
env:
2525
FORCE_COLOR: 0
2626
with:
27-
node-version: 20
27+
node-version: 24
2828
cache: npm
2929

3030
- name: Install Dependencies

.github/workflows/verify-node.yml

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,7 @@ jobs:
1414
fail-fast: false
1515
matrix:
1616
node-version:
17-
- '18'
18-
- '20'
19-
- '22'
20-
- 'latest'
17+
- '24'
2118

2219
steps:
2320
- uses: actions/checkout@v4
@@ -69,12 +66,12 @@ jobs:
6966
7067
- uses: actions/checkout@v4
7168

72-
- name: Setup Node '20'
69+
- name: Setup Node '24'
7370
uses: actions/setup-node@v4
7471
env:
7572
FORCE_COLOR: 0
7673
with:
77-
node-version: '20'
74+
node-version: '24'
7875
cache: 'npm'
7976

8077
# Set up GitHub Actions caching for Wireit.

.github/workflows/verify-storybook-builder.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,12 +16,12 @@ jobs:
1616
steps:
1717
- uses: actions/checkout@v4
1818

19-
- name: Setup Node 22
19+
- name: Setup Node 24
2020
uses: actions/setup-node@v4
2121
env:
2222
FORCE_COLOR: 0
2323
with:
24-
node-version: 22
24+
node-version: 24
2525
cache: npm
2626

2727
- name: Install Dependencies

packages/browser-logs/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,8 @@
2626
},
2727
"scripts": {
2828
"build": "tsc",
29-
"test:node": "TS_NODE_SKIP_PROJECT=true TS_NODE_COMPILER_OPTIONS='{\"module\":\"commonjs\",\"target\":\"ES2020\"}' mocha \"test/**/*.test.{ts,js,mjs,cjs}\" --require ts-node/register --reporter dot",
30-
"test:watch": "TS_NODE_SKIP_PROJECT=true TS_NODE_COMPILER_OPTIONS='{\"module\":\"commonjs\",\"target\":\"ES2020\"}' mocha \"test/**/*.test.{ts,js,mjs,cjs}\" --require ts-node/register --watch --watch-files src,test"
29+
"test:node": "mocha \"test/**/*.test.{ts,js,mjs,cjs}\" --require ts-node/register --reporter dot",
30+
"test:watch": "mocha \"test/**/*.test.{ts,js,mjs,cjs}\" --require ts-node/register --watch --watch-files src,test"
3131
},
3232
"files": [
3333
"*.d.ts",

packages/dev-server-core/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,8 +38,8 @@
3838
"start:event-stream": "node demo/event-stream/start-server.js",
3939
"start:http2": "node demo/http2/start-server.js",
4040
"start:import-asset": "node demo/import-asset/start-server.js",
41-
"test": "TS_NODE_SKIP_PROJECT=true TS_NODE_COMPILER_OPTIONS='{\"module\":\"commonjs\",\"target\":\"ES2020\"}' mocha \"test/**/*.test.{ts,js,mjs,cjs}\" --require ts-node/register --exit --reporter dot",
42-
"test:watch": "TS_NODE_SKIP_PROJECT=true TS_NODE_COMPILER_OPTIONS='{\"module\":\"commonjs\",\"target\":\"ES2020\"}' mocha \"test/**/*.test.{ts,js,mjs,cjs}\" --require ts-node/register --watch --watch-files src,test"
41+
"test": "mocha \"test/**/*.test.{ts,js,mjs,cjs}\" --require ts-node/register --exit --reporter dot",
42+
"test:watch": "mocha \"test/**/*.test.{ts,js,mjs,cjs}\" --require ts-node/register --watch --watch-files src,test"
4343
},
4444
"files": [
4545
".self-signed-dev-server-ssl.cert",

packages/dev-server-esbuild/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,8 @@
2828
"build": "tsc",
2929
"start:demo:jsx": "es-dev-server --config demo/jsx/server.config.js",
3030
"start:demo:ts": "es-dev-server --config demo/ts/server.config.js",
31-
"test:node": "TS_NODE_SKIP_PROJECT=true TS_NODE_COMPILER_OPTIONS='{\"module\":\"commonjs\",\"target\":\"ES2020\"}' mocha \"test/**/*.test.ts\" --require ts-node/register --reporter dot",
32-
"test:watch": "TS_NODE_SKIP_PROJECT=true TS_NODE_COMPILER_OPTIONS='{\"module\":\"commonjs\",\"target\":\"ES2020\"}' mocha \"test/**/*.test.ts\" --require ts-node/register --watch --watch-files src,test"
31+
"test:node": "mocha \"test/**/*.test.ts\" --require ts-node/register --reporter dot",
32+
"test:watch": "mocha \"test/**/*.test.ts\" --require ts-node/register --watch --watch-files src,test"
3333
},
3434
"files": [
3535
"*.d.ts",

packages/dev-server-hmr/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,8 @@
2828
"build": "tsc",
2929
"start:lit-html": "wds --config demo/lit-html/server.config.mjs",
3030
"start:vanilla": "wds --config demo/vanilla/server.config.mjs",
31-
"test:node": "TS_NODE_SKIP_PROJECT=true TS_NODE_COMPILER_OPTIONS='{\"module\":\"commonjs\",\"target\":\"ES2020\"}' mocha \"test/**/*.test.ts\" --require ts-node/register --reporter dot",
32-
"test:watch": "TS_NODE_SKIP_PROJECT=true TS_NODE_COMPILER_OPTIONS='{\"module\":\"commonjs\",\"target\":\"ES2020\"}' mocha \"test/**/*.test.ts\" --require ts-node/register --watch --watch-files src,test"
31+
"test:node": "mocha \"test/**/*.test.ts\" --require ts-node/register --reporter dot",
32+
"test:watch": "mocha \"test/**/*.test.ts\" --require ts-node/register --watch --watch-files src,test"
3333
},
3434
"files": [
3535
"*.d.ts",

packages/dev-server-import-maps/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,9 +26,9 @@
2626
},
2727
"scripts": {
2828
"build": "tsc",
29-
"test": "TS_NODE_SKIP_PROJECT=true TS_NODE_COMPILER_OPTIONS='{\"module\":\"commonjs\",\"target\":\"ES2020\"}' mocha \"test/**/*.test.ts\" --require ts-node/register",
29+
"test": "mocha \"test/**/*.test.ts\" --require ts-node/register",
3030
"test:browser": "node ../test-runner/dist/bin.js test-browser/test/**/*.test.{js,html} --config test-browser/web-test-runner.config.mjs",
31-
"test:watch": "TS_NODE_SKIP_PROJECT=true TS_NODE_COMPILER_OPTIONS='{\"module\":\"commonjs\",\"target\":\"ES2020\"}' mocha \"test/**/*.test.ts\" --require ts-node/register --watch --watch-files src,test"
31+
"test:watch": "mocha \"test/**/*.test.ts\" --require ts-node/register --watch --watch-files src,test"
3232
},
3333
"files": [
3434
"*.d.ts",

packages/dev-server-legacy/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,8 @@
2727
"scripts": {
2828
"build": "tsc",
2929
"start": "wds --open --config demo/server.config.mjs",
30-
"test:node": "TS_NODE_SKIP_PROJECT=true TS_NODE_COMPILER_OPTIONS='{\"module\":\"commonjs\",\"target\":\"ES2020\"}' mocha \"test/**/*.test.ts\" --require ts-node/register --reporter dot",
31-
"test:watch": "TS_NODE_SKIP_PROJECT=true TS_NODE_COMPILER_OPTIONS='{\"module\":\"commonjs\",\"target\":\"ES2020\"}' mocha \"test/**/*.test.ts\" --require ts-node/register --watch --watch-files src,test"
30+
"test:node": "mocha \"test/**/*.test.ts\" --require ts-node/register --reporter dot",
31+
"test:watch": "mocha \"test/**/*.test.ts\" --require ts-node/register --watch --watch-files src,test"
3232
},
3333
"files": [
3434
"*.d.ts",

0 commit comments

Comments
 (0)