Skip to content

Commit 963f2c0

Browse files
committed
fix: comprehensive type import fixes and test migration
- Fix integration test-runner .js -> .ts imports - Migrate test-runner-core tests from mocha to node:test - Migrate test-runner-chrome/playwright/puppeteer from mocha to node --test - Add node:test describe/it imports to all test files missing them - Fix all type-only imports across 25+ files (BrowserLauncher, TestRunnerCoreConfig, Logger, EntrypointBundle, etc.) - Fix playwright type imports (Browser, Page, LaunchOptions) - Fix polyfills-loader regenerator-runtime path (.js extension) - Add rollup-plugin-html test fixtures from fix/node24 - Remove unused beforeEach/afterEach imports - Fix BufferedLogger/TestSessionManager back to value imports Assisted-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent 03f027b commit 963f2c0

136 files changed

Lines changed: 417 additions & 125 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

integration/test-runner/index.ts

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
1-
import { BrowserLauncher, TestRunnerCoreConfig } from '@web/test-runner-core';
2-
import { runBasicTest } from './tests/basic/runBasicTest.js';
3-
import { runConfigGroupsTest } from './tests/config-groups/runConfigGroupsTest.js';
4-
import { runParallelTest } from './tests/parallel/runParallelTest.js';
5-
import { runTestFailureTest } from './tests/test-failure/runTestFailureTest.js';
6-
import { runLocationChangeTest } from './tests/location-change/runLocationChangeTest.js';
7-
import { runFocusTest } from './tests/focus/runFocusTest.js';
8-
import { runManyTests } from './tests/many/runManyTests.js';
1+
import type { BrowserLauncher, TestRunnerCoreConfig } from '@web/test-runner-core';
2+
import { runBasicTest } from './tests/basic/runBasicTest.ts';
3+
import { runConfigGroupsTest } from './tests/config-groups/runConfigGroupsTest.ts';
4+
import { runParallelTest } from './tests/parallel/runParallelTest.ts';
5+
import { runTestFailureTest } from './tests/test-failure/runTestFailureTest.ts';
6+
import { runLocationChangeTest } from './tests/location-change/runLocationChangeTest.ts';
7+
import { runFocusTest } from './tests/focus/runFocusTest.ts';
8+
import { runManyTests } from './tests/many/runManyTests.ts';
99

1010
export interface Tests {
1111
basic: boolean;

integration/test-runner/tests/basic/runBasicTest.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
1-
import { BrowserLauncher, TestRunnerCoreConfig, TestSession } from '@web/test-runner-core';
1+
import { describe, it } from 'node:test';
2+
import type { BrowserLauncher, TestRunnerCoreConfig, TestSession } from '@web/test-runner-core';
23
import { runTests } from '@web/test-runner-core/test-helpers';
34
import { legacyPlugin } from '@web/dev-server-legacy';
45
import { resolve } from 'path';
5-
import { expect } from 'chai';
66

77
export function runBasicTest(
88
config: Partial<TestRunnerCoreConfig> & { browsers: BrowserLauncher[] },

integration/test-runner/tests/config-groups/runConfigGroupsTest.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
1+
import { describe, it } from 'node:test';
12
import {
2-
BrowserLauncher,
3-
TestRunnerCoreConfig,
4-
TestRunnerGroupConfig,
3+
type BrowserLauncher,
4+
type TestRunnerCoreConfig,
5+
type TestRunnerGroupConfig,
56
} from '@web/test-runner-core';
67
import { runTests } from '@web/test-runner-core/test-helpers';
78
import { legacyPlugin } from '@web/dev-server-legacy';
89
import { resolve } from 'path';
9-
import { expect } from 'chai';
1010

1111
export function runConfigGroupsTest(
1212
config: Partial<TestRunnerCoreConfig> & { browsers: BrowserLauncher[] },

integration/test-runner/tests/focus/runFocusTest.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
1-
import { BrowserLauncher, TestRunnerCoreConfig, TestSession } from '@web/test-runner-core';
1+
import { describe, it } from 'node:test';
2+
import type { BrowserLauncher, TestRunnerCoreConfig, TestSession } from '@web/test-runner-core';
23
import { runTests } from '@web/test-runner-core/test-helpers';
34
import { legacyPlugin } from '@web/dev-server-legacy';
45
import { resolve } from 'path';
5-
import { expect } from 'chai';
66

77
export function runFocusTest(
88
config: Partial<TestRunnerCoreConfig> & { browsers: BrowserLauncher[] },

integration/test-runner/tests/location-change/runLocationChangeTest.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
1-
import { BrowserLauncher, TestRunnerCoreConfig, TestSession } from '@web/test-runner-core';
1+
import { describe, it } from 'node:test';
2+
import type { BrowserLauncher, TestRunnerCoreConfig, TestSession } from '@web/test-runner-core';
23
import { runTests } from '@web/test-runner-core/test-helpers';
34
import { legacyPlugin } from '@web/dev-server-legacy';
45
import { resolve } from 'path';
5-
import { expect } from 'chai';
66

77
export function runLocationChangeTest(
88
config: Partial<TestRunnerCoreConfig> & { browsers: BrowserLauncher[] },

integration/test-runner/tests/many/runManyTests.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
1-
import { BrowserLauncher, TestRunnerCoreConfig } from '@web/test-runner-core';
1+
import { describe, it } from 'node:test';
2+
import type { BrowserLauncher, TestRunnerCoreConfig } from '@web/test-runner-core';
23
import { runTests } from '@web/test-runner-core/test-helpers';
34
import { legacyPlugin } from '@web/dev-server-legacy';
45
import { resolve } from 'path';

integration/test-runner/tests/parallel/runParallelTest.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
1-
import { BrowserLauncher, TestRunnerCoreConfig } from '@web/test-runner-core';
1+
import { describe, it } from 'node:test';
2+
import type { BrowserLauncher, TestRunnerCoreConfig } from '@web/test-runner-core';
23
import { runTests } from '@web/test-runner-core/test-helpers';
34
import { legacyPlugin } from '@web/dev-server-legacy';
45
import { resolve } from 'path';

integration/test-runner/tests/test-failure/runTestFailureTest.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
1-
import { BrowserLauncher, TestRunnerCoreConfig, TestSession } from '@web/test-runner-core';
1+
import { describe, it } from 'node:test';
2+
import type { BrowserLauncher, TestRunnerCoreConfig, TestSession } from '@web/test-runner-core';
23
import { runTests } from '@web/test-runner-core/test-helpers';
34
import { legacyPlugin } from '@web/dev-server-legacy';
45
import { resolve, sep } from 'path';
5-
import { expect } from 'chai';
66

77
const ERROR_NOT_IMPORTABLE = {
88
message:

packages/dev-server-core/src/plugins/Plugin.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import { FSWatcher } from 'chokidar';
22
import type { Context } from 'koa';
33
import Koa from 'koa';
4-
import { Server } from 'net';
4+
import { type Server } from 'net';
55

66
import type { DevServerCoreConfig } from '../server/DevServerCoreConfig.ts';
77
import type { Logger } from '../logger/Logger.ts';

packages/dev-server-core/test/server/DevServer.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,11 @@ import assert from 'node:assert/strict';
33
import express from 'express';
44
import http from 'http';
55
import Koa from 'koa';
6-
import { Server } from 'net';
6+
import { type Server } from 'net';
77
import { FSWatcher } from 'chokidar';
88
import portfinder from 'portfinder';
99
import { Stub, stubMethod } from 'hanbi';
10-
import { ServerStartParams } from '../../src/plugins/Plugin.ts';
10+
import { type ServerStartParams } from '../../src/plugins/Plugin.ts';
1111
import { DevServer } from '../../src/server/DevServer.ts';
1212
import { createTestServer } from '../helpers.ts';
1313

0 commit comments

Comments
 (0)