chore: add explicit "type": "commonjs" to all CJS packages

bennypowers · bennypowers · commit c01bd4c5b113 · 2026-05-13T22:12:00.000+03:00
Node 22 enables --experimental-detect-module by default, which
reparses .ts test files as ESM when they contain import syntax.
This conflicts with mocha/ts-node's CommonJS require-based loading.

Adding explicit "type": "commonjs" removes the ambiguity and fixes
Node 22+ CI failures.

Assisted-By: Claude Opus 4.6 (1M context) &lt;noreply@anthropic.com&gt;
diff --git a/packages/browser-logs/package.json b/packages/browser-logs/package.json
@@ -1,5 +1,6 @@
 {
   "name": "@web/browser-logs",
+  "type": "commonjs",
   "version": "0.4.1",
   "publishConfig": {
     "access": "public"
diff --git a/packages/dev-server-core/package.json b/packages/dev-server-core/package.json
@@ -1,5 +1,6 @@
 {
   "name": "@web/dev-server-core",
+  "type": "commonjs",
   "version": "0.7.5",
   "publishConfig": {
     "access": "public"
diff --git a/packages/dev-server-esbuild/package.json b/packages/dev-server-esbuild/package.json
@@ -1,5 +1,6 @@
 {
   "name": "@web/dev-server-esbuild",
+  "type": "commonjs",
   "version": "1.0.5",
   "publishConfig": {
     "access": "public"
diff --git a/packages/dev-server-hmr/package.json b/packages/dev-server-hmr/package.json
@@ -1,5 +1,6 @@
 {
   "name": "@web/dev-server-hmr",
+  "type": "commonjs",
   "version": "0.4.1",
   "publishConfig": {
     "access": "public"
diff --git a/packages/dev-server-import-maps/package.json b/packages/dev-server-import-maps/package.json
@@ -1,5 +1,6 @@
 {
   "name": "@web/dev-server-import-maps",
+  "type": "commonjs",
   "version": "0.2.1",
   "publishConfig": {
     "access": "public"
diff --git a/packages/dev-server-legacy/package.json b/packages/dev-server-legacy/package.json
@@ -1,5 +1,6 @@
 {
   "name": "@web/dev-server-legacy",
+  "type": "commonjs",
   "version": "2.1.1",
   "publishConfig": {
     "access": "public"
diff --git a/packages/dev-server-rollup/package.json b/packages/dev-server-rollup/package.json
@@ -1,5 +1,6 @@
 {
   "name": "@web/dev-server-rollup",
+  "type": "commonjs",
   "version": "0.6.4",
   "publishConfig": {
     "access": "public"
diff --git a/packages/dev-server/package.json b/packages/dev-server/package.json
@@ -1,5 +1,6 @@
 {
   "name": "@web/dev-server",
+  "type": "commonjs",
   "version": "0.4.6",
   "publishConfig": {
     "access": "public"
diff --git a/packages/parse5-utils/package.json b/packages/parse5-utils/package.json
@@ -1,5 +1,6 @@
 {
   "name": "@web/parse5-utils",
+  "type": "commonjs",
   "version": "2.1.1",
   "publishConfig": {
     "access": "public"
diff --git a/packages/polyfills-loader/package.json b/packages/polyfills-loader/package.json
@@ -1,5 +1,6 @@
 {
   "name": "@web/polyfills-loader",
+  "type": "commonjs",
   "version": "2.3.1",
   "publishConfig": {
     "access": "public"
diff --git a/packages/rollup-plugin-copy/package.json b/packages/rollup-plugin-copy/package.json
@@ -1,5 +1,6 @@
 {
   "name": "@web/rollup-plugin-copy",
+  "type": "commonjs",
   "version": "0.5.1",
   "publishConfig": {
     "access": "public"
diff --git a/packages/rollup-plugin-html/package.json b/packages/rollup-plugin-html/package.json
@@ -1,5 +1,6 @@
 {
   "name": "@web/rollup-plugin-html",
+  "type": "commonjs",
   "version": "3.1.0",
   "publishConfig": {
     "access": "public"
diff --git a/packages/rollup-plugin-import-meta-assets/package.json b/packages/rollup-plugin-import-meta-assets/package.json
@@ -1,5 +1,6 @@
 {
   "name": "@web/rollup-plugin-import-meta-assets",
+  "type": "commonjs",
   "version": "2.3.3",
   "publishConfig": {
     "access": "public"
diff --git a/packages/rollup-plugin-polyfills-loader/package.json b/packages/rollup-plugin-polyfills-loader/package.json
@@ -1,5 +1,6 @@
 {
   "name": "@web/rollup-plugin-polyfills-loader",
+  "type": "commonjs",
   "version": "2.1.3",
   "publishConfig": {
     "access": "public"
diff --git a/packages/rollup-plugin-workbox/package.json b/packages/rollup-plugin-workbox/package.json
@@ -1,5 +1,6 @@
 {
   "name": "rollup-plugin-workbox",
+  "type": "commonjs",
   "version": "8.1.3",
   "description": "Rollup plugin that builds a service worker with workbox as part of your rollup build",
   "license": "MIT",
diff --git a/packages/storybook-builder/package.json b/packages/storybook-builder/package.json
@@ -1,5 +1,6 @@
 {
   "name": "@web/storybook-builder",
+  "type": "commonjs",
   "version": "0.3.0",
   "publishConfig": {
     "access": "public"
diff --git a/packages/storybook-framework-web-components/package.json b/packages/storybook-framework-web-components/package.json
@@ -1,5 +1,6 @@
 {
   "name": "@web/storybook-framework-web-components",
+  "type": "commonjs",
   "version": "0.3.0",
   "publishConfig": {
     "access": "public"
diff --git a/packages/test-runner-browserstack/package.json b/packages/test-runner-browserstack/package.json
@@ -1,5 +1,6 @@
 {
   "name": "@web/test-runner-browserstack",
+  "type": "commonjs",
   "version": "0.8.0",
   "publishConfig": {
     "access": "public"
diff --git a/packages/test-runner-chrome/package.json b/packages/test-runner-chrome/package.json
@@ -1,5 +1,6 @@
 {
   "name": "@web/test-runner-chrome",
+  "type": "commonjs",
   "version": "0.18.1",
   "publishConfig": {
     "access": "public"
diff --git a/packages/test-runner-cli/package.json b/packages/test-runner-cli/package.json
@@ -1,5 +1,6 @@
 {
   "name": "@web/test-runner-cli",
+  "type": "commonjs",
   "version": "0.11.0",
   "publishConfig": {
     "access": "public"
diff --git a/packages/test-runner-commands/package.json b/packages/test-runner-commands/package.json
@@ -1,5 +1,6 @@
 {
   "name": "@web/test-runner-commands",
+  "type": "commonjs",
   "version": "0.9.0",
   "publishConfig": {
     "access": "public"
diff --git a/packages/test-runner-core/package.json b/packages/test-runner-core/package.json
@@ -1,5 +1,6 @@
 {
   "name": "@web/test-runner-core",
+  "type": "commonjs",
   "version": "0.13.4",
   "publishConfig": {
     "access": "public"
diff --git a/packages/test-runner-coverage-v8/package.json b/packages/test-runner-coverage-v8/package.json
@@ -1,5 +1,6 @@
 {
   "name": "@web/test-runner-coverage-v8",
+  "type": "commonjs",
   "version": "0.8.0",
   "publishConfig": {
     "access": "public"
diff --git a/packages/test-runner-junit-reporter/package.json b/packages/test-runner-junit-reporter/package.json
@@ -1,5 +1,6 @@
 {
   "name": "@web/test-runner-junit-reporter",
+  "type": "commonjs",
   "version": "0.8.0",
   "publishConfig": {
     "access": "public"
diff --git a/packages/test-runner-mocha/package.json b/packages/test-runner-mocha/package.json
@@ -1,5 +1,6 @@
 {
   "name": "@web/test-runner-mocha",
+  "type": "commonjs",
   "version": "0.9.0",
   "publishConfig": {
     "access": "public"
diff --git a/packages/test-runner-playwright/package.json b/packages/test-runner-playwright/package.json
@@ -1,5 +1,6 @@
 {
   "name": "@web/test-runner-playwright",
+  "type": "commonjs",
   "version": "0.11.1",
   "publishConfig": {
     "access": "public"
diff --git a/packages/test-runner-puppeteer/package.json b/packages/test-runner-puppeteer/package.json
@@ -1,5 +1,6 @@
 {
   "name": "@web/test-runner-puppeteer",
+  "type": "commonjs",
   "version": "0.18.0",
   "publishConfig": {
     "access": "public"
diff --git a/packages/test-runner-saucelabs/package.json b/packages/test-runner-saucelabs/package.json
@@ -1,5 +1,6 @@
 {
   "name": "@web/test-runner-saucelabs",
+  "type": "commonjs",
   "version": "0.13.0",
   "publishConfig": {
     "access": "public"
diff --git a/packages/test-runner-selenium/package.json b/packages/test-runner-selenium/package.json
@@ -1,5 +1,6 @@
 {
   "name": "@web/test-runner-selenium",
+  "type": "commonjs",
   "version": "0.7.0",
   "publishConfig": {
     "access": "public"
diff --git a/packages/test-runner-visual-regression/package.json b/packages/test-runner-visual-regression/package.json
@@ -1,5 +1,6 @@
 {
   "name": "@web/test-runner-visual-regression",
+  "type": "commonjs",
   "version": "0.10.0",
   "publishConfig": {
     "access": "public"
diff --git a/packages/test-runner-webdriver/package.json b/packages/test-runner-webdriver/package.json
@@ -1,5 +1,6 @@
 {
   "name": "@web/test-runner-webdriver",
+  "type": "commonjs",
   "version": "0.9.0",
   "publishConfig": {
     "access": "public"
diff --git a/packages/test-runner/package.json b/packages/test-runner/package.json
@@ -1,5 +1,6 @@
 {
   "name": "@web/test-runner",
+  "type": "commonjs",
   "version": "0.20.2",
   "publishConfig": {
     "access": "public"

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "@web/browser-logs",`
	`3`	`+ "type": "commonjs",`
`3`	`4`	`"version": "0.4.1",`
`4`	`5`	`"publishConfig": {`
`5`	`6`	`"access": "public"`
Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "@web/dev-server-core",`
	`3`	`+ "type": "commonjs",`
`3`	`4`	`"version": "0.7.5",`
`4`	`5`	`"publishConfig": {`
`5`	`6`	`"access": "public"`
Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "@web/dev-server-esbuild",`
	`3`	`+ "type": "commonjs",`
`3`	`4`	`"version": "1.0.5",`
`4`	`5`	`"publishConfig": {`
`5`	`6`	`"access": "public"`
Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "@web/dev-server-hmr",`
	`3`	`+ "type": "commonjs",`
`3`	`4`	`"version": "0.4.1",`
`4`	`5`	`"publishConfig": {`
`5`	`6`	`"access": "public"`
Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "@web/dev-server-import-maps",`
	`3`	`+ "type": "commonjs",`
`3`	`4`	`"version": "0.2.1",`
`4`	`5`	`"publishConfig": {`
`5`	`6`	`"access": "public"`
Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "@web/dev-server-legacy",`
	`3`	`+ "type": "commonjs",`
`3`	`4`	`"version": "2.1.1",`
`4`	`5`	`"publishConfig": {`
`5`	`6`	`"access": "public"`
Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "@web/dev-server-rollup",`
	`3`	`+ "type": "commonjs",`
`3`	`4`	`"version": "0.6.4",`
`4`	`5`	`"publishConfig": {`
`5`	`6`	`"access": "public"`
Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "@web/dev-server",`
	`3`	`+ "type": "commonjs",`
`3`	`4`	`"version": "0.4.6",`
`4`	`5`	`"publishConfig": {`
`5`	`6`	`"access": "public"`
Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "@web/parse5-utils",`
	`3`	`+ "type": "commonjs",`
`3`	`4`	`"version": "2.1.1",`
`4`	`5`	`"publishConfig": {`
`5`	`6`	`"access": "public"`
Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "@web/polyfills-loader",`
	`3`	`+ "type": "commonjs",`
`3`	`4`	`"version": "2.3.1",`
`4`	`5`	`"publishConfig": {`
`5`	`6`	`"access": "public"`