Skip to content

Commit f813e66

Browse files
committed
fix: fix browser-logs stack trace assertions and add test timeouts
- Replace hardcoded column offsets (N:23) with regex patterns (N:\d+) in browser-logs error stack trace tests. Column offsets vary by browser version and shouldn't be hardcoded. - Add --test-timeout 120000 to all node --test commands to prevent 30-minute hangs on Windows when a test server fails to shut down. Assisted-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent fc5426d commit f813e66

22 files changed

Lines changed: 42 additions & 42 deletions

File tree

packages/browser-logs/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626
},
2727
"scripts": {
2828
"build": "tsc",
29-
"test:node": "node --experimental-transform-types --test test/**/*.test.ts",
29+
"test:node": "node --experimental-transform-types --test --test-timeout 120000 test/**/*.test.ts",
3030
"test:watch": "node --experimental-transform-types --test --watch test/**/*.test.ts"
3131
},
3232
"files": [

packages/browser-logs/test/serialize-deserialize.test.ts

Lines changed: 18 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -350,9 +350,9 @@ describe('serialize deserialize', function () {
350350
const deserialized = await deserialize(serialized, defaultOptions);
351351
assert.strictEqual(typeof deserialized, 'string');
352352
assert.ok(deserialized.includes('my error msg'));
353-
assert.ok(deserialized.includes('2:23'));
354-
assert.ok(deserialized.includes('3:23'));
355-
assert.ok(deserialized.includes('4:23'));
353+
assert.ok(/2:\d+/.test(deserialized));
354+
assert.ok(/3:\d+/.test(deserialized));
355+
assert.ok(/4:\d+/.test(deserialized));
356356
});
357357

358358
it('handles errors in objects', async () => {
@@ -365,9 +365,9 @@ describe('serialize deserialize', function () {
365365
const deserialized = await deserialize(serialized, defaultOptions);
366366
assert.strictEqual(typeof deserialized.myError, 'string');
367367
assert.ok(deserialized.myError.includes('my error msg'));
368-
assert.ok(deserialized.myError.includes('2:23'));
369-
assert.ok(deserialized.myError.includes('3:23'));
370-
assert.ok(deserialized.myError.includes('4:23'));
368+
assert.ok(/2:\d+/.test(deserialized.myError));
369+
assert.ok(/3:\d+/.test(deserialized.myError));
370+
assert.ok(/4:\d+/.test(deserialized.myError));
371371
});
372372

373373
it('handles errors in arrays', async () => {
@@ -380,16 +380,16 @@ describe('serialize deserialize', function () {
380380
const deserialized = await deserialize(serialized, defaultOptions);
381381
assert.strictEqual(typeof deserialized[0], 'string');
382382
assert.ok(deserialized[0].includes('my error msg'));
383-
assert.ok(deserialized[0].includes('2:23'));
384-
assert.ok(deserialized[0].includes('3:23'));
385-
assert.ok(deserialized[0].includes('4:23'));
383+
assert.ok(/2:\d+/.test(deserialized[0]));
384+
assert.ok(/3:\d+/.test(deserialized[0]));
385+
assert.ok(/4:\d+/.test(deserialized[0]));
386386
assert.strictEqual(typeof deserialized[1], 'string');
387387
assert.ok(deserialized[1].includes('my error msg'));
388-
assert.ok(deserialized[1].includes('2:23'));
389-
assert.ok(deserialized[1].includes('3:23'));
388+
assert.ok(/2:\d+/.test(deserialized[1]));
389+
assert.ok(/3:\d+/.test(deserialized[1]));
390390
assert.strictEqual(typeof deserialized[2], 'string');
391391
assert.ok(deserialized[2].includes('my error msg'));
392-
assert.ok(deserialized[2].includes('2:23'));
392+
assert.ok(/2:\d+/.test(deserialized[2]));
393393
});
394394

395395
it('can map stack trace locations', async () => {
@@ -440,9 +440,9 @@ describe('serialize deserialize', function () {
440440
});
441441
assert.strictEqual(typeof deserialized, 'string');
442442
assert.ok(deserialized.includes('my error msg'));
443-
assert.ok(deserialized.includes(`2:23`));
444-
assert.ok(deserialized.includes(`3:23`));
445-
assert.ok(deserialized.includes(`4:23`));
443+
assert.ok(/2:\d+/.test(deserialized));
444+
assert.ok(/3:\d+/.test(deserialized));
445+
assert.ok(/4:\d+/.test(deserialized));
446446
});
447447

448448
it('can define a cwd above current directory', async () => {
@@ -458,9 +458,9 @@ describe('serialize deserialize', function () {
458458
});
459459
assert.strictEqual(typeof deserialized, 'string');
460460
assert.ok(deserialized.includes('my error msg'));
461-
assert.ok(deserialized.includes(`2:23`));
462-
assert.ok(deserialized.includes(`3:23`));
463-
assert.ok(deserialized.includes(`4:23`));
461+
assert.ok(/2:\d+/.test(deserialized));
462+
assert.ok(/3:\d+/.test(deserialized));
463+
assert.ok(/4:\d+/.test(deserialized));
464464
});
465465

466466
it('handles null', async () => {

packages/config-loader/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
},
2121
"scripts": {
2222
"build": "tsc",
23-
"test:node": "node --experimental-transform-types --test 'test/**/*.test.mjs'",
23+
"test:node": "node --experimental-transform-types --test --test-timeout 120000 'test/**/*.test.mjs'",
2424
"test:watch": "node --experimental-transform-types --test --watch 'test/**/*.test.mjs'"
2525
},
2626
"files": [

packages/dev-server-core/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@
4141
"start:event-stream": "node demo/event-stream/start-server.js",
4242
"start:http2": "node demo/http2/start-server.js",
4343
"start:import-asset": "node demo/import-asset/start-server.js",
44-
"test": "node --experimental-transform-types --test \"test/**/*.test.ts\"",
44+
"test": "node --experimental-transform-types --test --test-timeout 120000 \"test/**/*.test.ts\"",
4545
"test:watch": "node --experimental-transform-types --test --watch \"test/**/*.test.ts\""
4646
},
4747
"files": [

packages/dev-server-esbuild/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
"build": "tsc",
2929
"start:demo:jsx": "es-dev-server --config demo/jsx/server.config.js",
3030
"start:demo:ts": "es-dev-server --config demo/ts/server.config.js",
31-
"test:node": "node --experimental-transform-types --test test/**/*.test.ts",
31+
"test:node": "node --experimental-transform-types --test --test-timeout 60000 test/**/*.test.ts",
3232
"test:watch": "node --experimental-transform-types --test --watch test/**/*.test.ts"
3333
},
3434
"files": [

packages/dev-server-hmr/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
"build": "tsc",
2929
"start:lit-html": "wds --config demo/lit-html/server.config.mjs",
3030
"start:vanilla": "wds --config demo/vanilla/server.config.mjs",
31-
"test:node": "node --experimental-transform-types --test 'test/**/*.test.ts'",
31+
"test:node": "node --experimental-transform-types --test --test-timeout 120000 'test/**/*.test.ts'",
3232
"test:watch": "node --experimental-transform-types --test --watch 'test/**/*.test.ts'"
3333
},
3434
"files": [

packages/dev-server-import-maps/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626
},
2727
"scripts": {
2828
"build": "tsc",
29-
"test": "node --experimental-transform-types --test test/**/*.test.ts",
29+
"test": "node --experimental-transform-types --test --test-timeout 120000 test/**/*.test.ts",
3030
"test:browser": "node ../test-runner/dist/bin.js test-browser/test/**/*.test.{js,html} --config test-browser/web-test-runner.config.mjs",
3131
"test:watch": "node --experimental-transform-types --test --watch test/**/*.test.ts"
3232
},

packages/dev-server-legacy/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
"scripts": {
2828
"build": "tsc",
2929
"start": "wds --open --config demo/server.config.mjs",
30-
"test:node": "node --experimental-transform-types --test test/**/*.test.ts",
30+
"test:node": "node --experimental-transform-types --test --test-timeout 120000 test/**/*.test.ts",
3131
"test:watch": "node --experimental-transform-types --test --watch test/**/*.test.ts"
3232
},
3333
"files": [

packages/dev-server-rollup/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
"node": ">=18.0.0"
2626
},
2727
"scripts": {
28-
"test:node": "node --experimental-transform-types --test \"test/node/**/*.test.ts\"",
28+
"test:node": "node --experimental-transform-types --test --test-timeout 120000 \"test/node/**/*.test.ts\"",
2929
"test:watch": "node --experimental-transform-types --test --watch \"test/node/**/*.test.ts\""
3030
},
3131
"files": [

packages/dev-server/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@
3737
"start:plugin-serve": "node dist/bin.js --config demo/plugin-serve/config.mjs --open",
3838
"start:static": "node dist/bin.js --config demo/static/config.mjs --open demo/static/",
3939
"start:syntax": "node dist/bin.js --config demo/syntax/config.mjs --open demo/syntax/",
40-
"test:node": "node --experimental-transform-types --test 'test/**/*.test.mjs'",
40+
"test:node": "node --experimental-transform-types --test --test-timeout 120000 'test/**/*.test.mjs'",
4141
"test:watch": "node --experimental-transform-types --test --watch 'test/**/*.test.mjs'"
4242
},
4343
"files": [

0 commit comments

Comments
 (0)