Skip to content

Commit ff93447

Browse files
committed
refactor: use import type for type-only imports across all packages
Add explicit `type` annotations to all type-only imports and exports. This is a pure TypeScript syntax change with no runtime effect -- the compiled JavaScript output is identical. It prepares for Node 24's type stripping, which requires `import type` for type-only imports since they are erased at runtime. 93 files changed across dev-server, test-runner, rollup-plugin, and storybook packages. Assisted-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent 1141a47 commit ff93447

73 files changed

Lines changed: 203 additions & 176 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

packages/dev-server-core/src/plugins/Plugin.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
import { FSWatcher } from 'chokidar';
22
import Koa, { Context } from 'koa';
3-
import { Server } from 'net';
3+
import { type Server } from 'net';
44

5-
import { DevServerCoreConfig } from '../server/DevServerCoreConfig';
6-
import { Logger } from '../logger/Logger';
5+
import type { DevServerCoreConfig } from '../server/DevServerCoreConfig';
6+
import type { Logger } from '../logger/Logger';
77
import { WebSocketsManager } from '../web-sockets/WebSocketsManager';
88

99
export type ServeResult =

packages/dev-server-core/src/server/createServer.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,9 @@ import http2Server from 'http2';
66
import fs from 'fs';
77
import net, { Server, Socket, ListenOptions } from 'net';
88

9-
import { DevServerCoreConfig } from './DevServerCoreConfig.js';
9+
import type { DevServerCoreConfig } from './DevServerCoreConfig.js';
1010
import { createMiddleware } from './createMiddleware.js';
11-
import { Logger } from '../logger/Logger.js';
11+
import type { Logger } from '../logger/Logger.js';
1212
import { addPlugins } from './addPlugins.js';
1313

1414
/**
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
export { RollupNodeResolveOptions, nodeResolve } from '@rollup/plugin-node-resolve';
1+
export { type RollupNodeResolveOptions, nodeResolve } from '@rollup/plugin-node-resolve';
22
export { fromRollup } from './fromRollup.js';
33
export { rollupAdapter } from './rollupAdapter.js';
44
export { rollupBundlePlugin } from './rollupBundlePlugin.js';

packages/dev-server/src/config/DevServerConfig.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
import { DevServerCoreConfig } from '@web/dev-server-core';
2-
import { RollupNodeResolveOptions } from '@web/dev-server-rollup';
1+
import { type DevServerCoreConfig } from '@web/dev-server-core';
2+
import { type RollupNodeResolveOptions } from '@web/dev-server-rollup';
33

44
export interface DevServerConfig extends DevServerCoreConfig {
55
/**

packages/dev-server/src/config/mergeConfigs.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { DevServerConfig } from './DevServerConfig.js';
1+
import { type DevServerConfig } from './DevServerConfig.js';
22

33
const arrayKeys = ['plugins', 'middleware'];
44

packages/dev-server/src/config/parseConfig.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
import { getPortPromise } from 'portfinder';
22
import path from 'path';
33

4-
import { DevServerCliArgs } from './readCliArgs.js';
4+
import { type DevServerCliArgs } from './readCliArgs.js';
55
import { mergeConfigs } from './mergeConfigs.js';
6-
import { DevServerConfig } from './DevServerConfig.js';
6+
import { type DevServerConfig } from './DevServerConfig.js';
77
import { esbuildPlugin } from '../plugins/esbuildPlugin.js';
88
import { watchPlugin } from '../plugins/watchPlugin.js';
99
import { nodeResolvePlugin } from '../plugins/nodeResolvePlugin.js';

packages/dev-server/src/config/readCliArgs.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import commandLineArgs from 'command-line-args';
22
import commandLineUsage, { OptionDefinition } from 'command-line-usage';
33
import camelCase from 'camelcase';
4-
import { DevServerConfig } from './DevServerConfig.js';
4+
import { type DevServerConfig } from './DevServerConfig.js';
55

66
export interface DevServerCliArgs
77
extends Partial<

packages/dev-server/src/logger/DevServerLogger.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { Logger, PluginSyntaxError } from '@web/dev-server-core';
1+
import { type Logger, PluginSyntaxError } from '@web/dev-server-core';
22
import { codeFrameColumns } from '@babel/code-frame';
33
import path from 'path';
44
import { red, cyan } from 'nanocolors';

packages/dev-server/src/logger/createLogger.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { Plugin } from '@web/dev-server-core';
1+
import { type Plugin } from '@web/dev-server-core';
22
import { DevServerLogger } from './DevServerLogger.js';
33
import { logStartMessage } from './logStartMessage.js';
44

packages/dev-server/src/logger/logStartMessage.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
import { DevServerConfig } from '../config/DevServerConfig';
2-
import { Logger } from '@web/dev-server-core';
1+
import { type DevServerConfig } from '../config/DevServerConfig';
2+
import { type Logger } from '@web/dev-server-core';
33
import internalIp from 'internal-ip';
44
import { bold, cyan, white } from 'nanocolors';
55

0 commit comments

Comments
 (0)