-
-
Notifications
You must be signed in to change notification settings - Fork 334
refactor(test-runner-junit-reporter): migrate tests to node:test #3091
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
bennypowers
wants to merge
2
commits into
master
Choose a base branch
from
migrate/test-runner-junit-reporter-node-test
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
22 changes: 11 additions & 11 deletions
22
packages/test-runner-junit-reporter/test/fixtures/multiple/expected.xml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,28 +1,28 @@ | ||
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <testsuites> | ||
| <testsuite name="Chrome_puppeteer_/packages/test-runner-junit-reporter/test/fixtures/multiple/nested-test.js" id="0" tests="1" skipped="0" errors="0" failures="0" time="<<computed>>"> | ||
| <testsuite name="Chrome_puppeteer_/test/fixtures/multiple/nested-test.js" id="0" tests="1" skipped="0" errors="0" failures="0" time="<<computed>>"> | ||
| <properties> | ||
| <property name="test.fileName" value="packages/test-runner-junit-reporter/test/fixtures/multiple/nested-test.js"/> | ||
| <property name="test.fileName" value="test/fixtures/multiple/nested-test.js"/> | ||
| <property name="browser.name" value="Chrome"/> | ||
| <property name="browser.launcher" value="puppeteer"/> | ||
| </properties> | ||
| <testcase name="is equivalent to map (f.g) f a" time="<<computed>>" classname="given a functor f and a function a -> b map f map g f a" file="packages/test-runner-junit-reporter/test/fixtures/multiple/nested-test.js"/> | ||
| <testcase name="is equivalent to map (f.g) f a" time="<<computed>>" classname="given a functor f and a function a -> b map f map g f a" file="test/fixtures/multiple/nested-test.js"/> | ||
| </testsuite> | ||
| <testsuite name="Chrome_puppeteer_/packages/test-runner-junit-reporter/test/fixtures/multiple/simple-test.js" id="0" tests="5" skipped="1" errors="1" failures="1" time="<<computed>>"> | ||
| <testsuite name="Chrome_puppeteer_/test/fixtures/multiple/simple-test.js" id="0" tests="5" skipped="1" errors="1" failures="1" time="<<computed>>"> | ||
| <properties> | ||
| <property name="test.fileName" value="packages/test-runner-junit-reporter/test/fixtures/multiple/simple-test.js"/> | ||
| <property name="test.fileName" value="test/fixtures/multiple/simple-test.js"/> | ||
| <property name="browser.name" value="Chrome"/> | ||
| <property name="browser.launcher" value="puppeteer"/> | ||
| </properties> | ||
| <testcase name="under addition" time="<<computed>>" classname="real numbers forming a monoid" file="packages/test-runner-junit-reporter/test/fixtures/multiple/simple-test.js"/> | ||
| <testcase name="null hypothesis" time="<<computed>>" classname="off-by-one boolean logic errors" file="packages/test-runner-junit-reporter/test/fixtures/multiple/simple-test.js"/> | ||
| <testcase name="asserts error" time="<<computed>>" classname="off-by-one boolean logic errors" file="packages/test-runner-junit-reporter/test/fixtures/multiple/simple-test.js" line="15"> | ||
| <testcase name="under addition" time="<<computed>>" classname="real numbers forming a monoid" file="test/fixtures/multiple/simple-test.js"/> | ||
| <testcase name="null hypothesis" time="<<computed>>" classname="off-by-one boolean logic errors" file="test/fixtures/multiple/simple-test.js"/> | ||
| <testcase name="asserts error" time="<<computed>>" classname="off-by-one boolean logic errors" file="test/fixtures/multiple/simple-test.js" line="15"> | ||
| <failure message="expected false to be true" type="AssertionError"><![CDATA[AssertionError: expected false to be true | ||
| at <<anonymous>> (packages/test-runner-junit-reporter/test/fixtures/multiple/simple-test.js:15:29)]]></failure> | ||
| at <<anonymous>> (test/fixtures/multiple/simple-test.js:15:29)]]></failure> | ||
| </testcase> | ||
| <testcase name="tbd: confirm true positive" time="<<computed>>" classname="off-by-one boolean logic errors" file="packages/test-runner-junit-reporter/test/fixtures/multiple/simple-test.js"> | ||
| <testcase name="tbd: confirm true positive" time="<<computed>>" classname="off-by-one boolean logic errors" file="test/fixtures/multiple/simple-test.js"> | ||
| <skipped/> | ||
| </testcase> | ||
| <testcase name="reports logs to JUnit" time="<<computed>>" classname="logging during a test" file="packages/test-runner-junit-reporter/test/fixtures/multiple/simple-test.js"/> | ||
| <testcase name="reports logs to JUnit" time="<<computed>>" classname="logging during a test" file="test/fixtures/multiple/simple-test.js"/> | ||
| </testsuite> | ||
| </testsuites> | ||
6 changes: 3 additions & 3 deletions
6
packages/test-runner-junit-reporter/test/fixtures/nested/expected.xml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,11 +1,11 @@ | ||
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <testsuites> | ||
| <testsuite name="Chrome_puppeteer_/packages/test-runner-junit-reporter/test/fixtures/nested/nested-test.js" id="0" tests="1" skipped="0" errors="0" failures="0" time="<<computed>>"> | ||
| <testsuite name="Chrome_puppeteer_/test/fixtures/nested/nested-test.js" id="0" tests="1" skipped="0" errors="0" failures="0" time="<<computed>>"> | ||
| <properties> | ||
| <property name="test.fileName" value="packages/test-runner-junit-reporter/test/fixtures/nested/nested-test.js"/> | ||
| <property name="test.fileName" value="test/fixtures/nested/nested-test.js"/> | ||
| <property name="browser.name" value="Chrome"/> | ||
| <property name="browser.launcher" value="puppeteer"/> | ||
| </properties> | ||
| <testcase name="is equivalent to map (f.g) f a" time="<<computed>>" classname="given a functor f and a function a -> b map f map g f a" file="packages/test-runner-junit-reporter/test/fixtures/nested/nested-test.js"/> | ||
| <testcase name="is equivalent to map (f.g) f a" time="<<computed>>" classname="given a functor f and a function a -> b map f map g f a" file="test/fixtures/nested/nested-test.js"/> | ||
| </testsuite> | ||
| </testsuites> |
22 changes: 11 additions & 11 deletions
22
packages/test-runner-junit-reporter/test/fixtures/simple/expected.xml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,25 +1,25 @@ | ||
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <testsuites> | ||
| <testsuite name="Chrome_puppeteer_/packages/test-runner-junit-reporter/test/fixtures/simple/simple-test.js" id="0" tests="6" skipped="1" errors="2" failures="2" time="<<computed>>"> | ||
| <testsuite name="Chrome_puppeteer_/test/fixtures/simple/simple-test.js" id="0" tests="6" skipped="1" errors="2" failures="2" time="<<computed>>"> | ||
| <properties> | ||
| <property name="test.fileName" value="packages/test-runner-junit-reporter/test/fixtures/simple/simple-test.js"/> | ||
| <property name="test.fileName" value="test/fixtures/simple/simple-test.js"/> | ||
| <property name="browser.name" value="Chrome"/> | ||
| <property name="browser.launcher" value="puppeteer"/> | ||
| </properties> | ||
| <testcase name="under addition" time="<<computed>>" classname="real numbers forming a monoid" file="packages/test-runner-junit-reporter/test/fixtures/simple/simple-test.js"/> | ||
| <testcase name="null hypothesis" time="<<computed>>" classname="off-by-one boolean logic errors" file="packages/test-runner-junit-reporter/test/fixtures/simple/simple-test.js"/> | ||
| <testcase name="asserts error" time="<<computed>>" classname="off-by-one boolean logic errors" file="packages/test-runner-junit-reporter/test/fixtures/simple/simple-test.js" line="17"> | ||
| <testcase name="under addition" time="<<computed>>" classname="real numbers forming a monoid" file="test/fixtures/simple/simple-test.js"/> | ||
| <testcase name="null hypothesis" time="<<computed>>" classname="off-by-one boolean logic errors" file="test/fixtures/simple/simple-test.js"/> | ||
| <testcase name="asserts error" time="<<computed>>" classname="off-by-one boolean logic errors" file="test/fixtures/simple/simple-test.js" line="17"> | ||
| <failure message="expected false to be true" type="AssertionError"><![CDATA[AssertionError: expected false to be true | ||
| at <<anonymous>> (packages/test-runner-junit-reporter/test/fixtures/simple/simple-test.js:17:29)]]></failure> | ||
| at <<anonymous>> (test/fixtures/simple/simple-test.js:17:29)]]></failure> | ||
| </testcase> | ||
| <testcase name="tbd: confirm true positive" time="<<computed>>" classname="off-by-one boolean logic errors" file="packages/test-runner-junit-reporter/test/fixtures/simple/simple-test.js"> | ||
| <testcase name="tbd: confirm true positive" time="<<computed>>" classname="off-by-one boolean logic errors" file="test/fixtures/simple/simple-test.js"> | ||
| <skipped/> | ||
| </testcase> | ||
| <testcase name="reports logs to JUnit" time="<<computed>>" classname="logging during a test" file="packages/test-runner-junit-reporter/test/fixtures/simple/simple-test.js"/> | ||
| <testcase name="fails with source trace" time="<<computed>>" classname="logging during a test" file="packages/test-runner-junit-reporter/test/fixtures/simple/simple-test.js" line="2"> | ||
| <testcase name="reports logs to JUnit" time="<<computed>>" classname="logging during a test" file="test/fixtures/simple/simple-test.js"/> | ||
| <testcase name="fails with source trace" time="<<computed>>" classname="logging during a test" file="test/fixtures/simple/simple-test.js" line="2"> | ||
| <failure message="failed" type="Error"><![CDATA[Error: failed | ||
| at fail (packages/test-runner-junit-reporter/test/fixtures/simple/simple-source.js:2:9) | ||
| at <<anonymous>> (packages/test-runner-junit-reporter/test/fixtures/simple/simple-test.js:33:17)]]></failure> | ||
| at fail (test/fixtures/simple/simple-source.js:2:9) | ||
| at <<anonymous>> (test/fixtures/simple/simple-test.js:33:17)]]></failure> | ||
| </testcase> | ||
| </testsuite> | ||
| </testsuites> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not familiar with junit reporter, so not sure how critical this is, but a little strange to see this path change
is this a result of this change in the implementation?
if yes, was this intentional? maybe best to make it work in such a way that this file doesn't change in the PR