Skip to content

chore: use python>=3.10 in conda env, fix map plot example#2501

Merged
wpbonelli merged 1 commit into
modflowpy:developfrom
wpbonelli:chores
May 5, 2025
Merged

chore: use python>=3.10 in conda env, fix map plot example#2501
wpbonelli merged 1 commit into
modflowpy:developfrom
wpbonelli:chores

Conversation

@wpbonelli

@wpbonelli wpbonelli commented May 5, 2025

Copy link
Copy Markdown
Member

Fix a problem in example notebook CI. The delete parameter to TemporaryDirectory was added in Python 3.12, but we still want to support >=3.10. Also the environment.yml still had a lower bound of 3.9, bump it.

@wpbonelli wpbonelli merged commit 82d9806 into modflowpy:develop May 5, 2025
@wpbonelli wpbonelli deleted the chores branch May 5, 2025 11:59
@codecov

codecov Bot commented May 5, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.1%. Comparing base (7eb7c88) to head (f4c503d).
Report is 11 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff           @@
##           develop   #2501   +/-   ##
=======================================
  Coverage     76.1%   76.1%           
=======================================
  Files          296     296           
  Lines        64215   64215           
=======================================
  Hits         48885   48885           
  Misses       15330   15330           

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant