Skip to content

fix: update numpy array comparisons to use isin#2504

Merged
wpbonelli merged 1 commit into
modflowpy:developfrom
emmanuel-ferdman:develop
May 6, 2025
Merged

fix: update numpy array comparisons to use isin#2504
wpbonelli merged 1 commit into
modflowpy:developfrom
emmanuel-ferdman:develop

Conversation

@emmanuel-ferdman

Copy link
Copy Markdown
Contributor

PR Summary

This small PR resolves the deprecation warnings coming from np.in1d:

/home/runner/work/flopy/flopy/flopy/utils/zonbud.py:1031: DeprecationWarning: `in1d` is deprecated. Use `np.isin` instea

Signed-off-by: Emmanuel Ferdman <emmanuelferdman@gmail.com>
@codecov

codecov Bot commented May 6, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.1%. Comparing base (7eb7c88) to head (3e99258).
Report is 13 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2504      +/-   ##
===========================================
- Coverage     76.1%    56.1%   -20.1%     
===========================================
  Files          296      640     +344     
  Lines        64215   124323   +60108     
===========================================
+ Hits         48885    69747   +20862     
- Misses       15330    54576   +39246     
Files with missing lines Coverage Δ
flopy/utils/zonbud.py 66.8% <ø> (ø)

... and 475 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@wpbonelli wpbonelli left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@wpbonelli wpbonelli merged commit 0d9c914 into modflowpy:develop May 6, 2025
31 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants