fix(mfsimulation): respect max_columns_of_data for internal arrays#2665
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2665 +/- ##
===========================================
+ Coverage 55.5% 72.6% +17.1%
===========================================
Files 644 667 +23
Lines 124135 129386 +5251
===========================================
+ Hits 68947 94018 +25071
+ Misses 55188 35368 -19820
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #2420, only internal arrays in this PR. Introduce a single underlying variable to track whether
max_columns_of_datahas been set automatically or by the user. Keep the 2 existing user-facing flags for backwards-compatibility, but reimplemented as properties to reflect the neater internal management. This should eliminate the need to ever set these.And reproduce the external array problem. There are tricky interactions between whether
max_columns_of_datais set first or data is set external first, and whether the simulation workspace has been changed. Currently the column setting is only respected for external arrays if the simulation workspace has been changed and the column setting is set before setting data external. Ideally the setting would be respected regardless of order of ops or whether the workspace is different.