fix(lgrutil): remove duplicate hanging vertices#2672
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #2672 +/- ##
===========================================
+ Coverage 55.5% 72.7% +17.1%
===========================================
Files 644 667 +23
Lines 124135 129574 +5439
===========================================
+ Hits 68947 94222 +25275
+ Misses 55188 35352 -19836
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lgr.to_disv_gridprops()left duplicate hanging vertices in the generated grid. Fix it by adding deduplication logic after vertices are collected. Some variables to record hanging vertices already existed, seems like this was intended but left out of the implementation.Now the only substantive difference between
cvfdutil.gridlist_to_disv_gridpropsand theLgrapproach is that the former includes "wraparound" vertices, which MF6 considers unnecessary.Noticed this in MODFLOW-ORG/modflow6-examples#319 while switching to the
Lgrapproach.Some of the test code here will be very short-lived given #2667 but I'm including it just to bake it into the git log for the benefit of any future forensics