Skip to content

fix(mp7): fix input file writing#2679

Merged
wpbonelli merged 4 commits into
modflowpy:developfrom
wpbonelli:fix-particle-group
Jan 9, 2026
Merged

fix(mp7): fix input file writing#2679
wpbonelli merged 4 commits into
modflowpy:developfrom
wpbonelli:fix-particle-group

Conversation

@wpbonelli

@wpbonelli wpbonelli commented Jan 9, 2026

Copy link
Copy Markdown
Member

Util2d assumes its first argument is a model, but a ParticleGroup was being passed. This caused an error when writing MP7 input files with certain release configurations. Don't pass ParticleGroup to Util2d as it's not needed, and only check self.model in Util2d if it's not None. Likewise in the ArrayFormat class.

@codecov

codecov Bot commented Jan 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.8%. Comparing base (556c088) to head (a7b6f4c).
⚠️ Report is 105 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2679      +/-   ##
===========================================
+ Coverage     55.5%    72.8%   +17.2%     
===========================================
  Files          644      667      +23     
  Lines       124135   130092    +5957     
===========================================
+ Hits         68947    94715   +25768     
+ Misses       55188    35377   -19811     
Files with missing lines Coverage Δ
flopy/modpath/mp7particlegroup.py 89.2% <100.0%> (+5.0%) ⬆️
flopy/utils/util_array.py 83.1% <100.0%> (-0.3%) ⬇️

... and 559 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@wpbonelli wpbonelli added the bug label Jan 9, 2026
@wpbonelli wpbonelli added this to the 3.9.6 milestone Jan 9, 2026
@wpbonelli wpbonelli marked this pull request as ready for review January 9, 2026 16:08
@wpbonelli wpbonelli merged commit bef063f into modflowpy:develop Jan 9, 2026
19 checks passed
@wpbonelli wpbonelli modified the milestones: 3.9.6, 3.10 Jan 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant