Skip to content

Commit 24e92e5

Browse files
authored
tgc: fix diffs for container cluster (GoogleCloudPlatform#17488)
1 parent 9276451 commit 24e92e5

2 files changed

Lines changed: 13 additions & 6 deletions

File tree

mmv1/products/container/Cluster.yaml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -94,6 +94,12 @@ properties:
9494
type: 'String'
9595
description: 'The selected network policy provider.'
9696
is_missing_in_cai: true
97+
- name: minMasterVersion
98+
type: String
99+
ignore_read: true
100+
- name: nodeVersion
101+
type: String
102+
ignore_read: true
97103
tgc_tests:
98104
- name: TestAccContainerCluster_withDatabaseEncryption
99105
skip: Bug in the API, https://github.com/hashicorp/terraform-provider-google/issues/26882

mmv1/third_party/tgc_next/pkg/services/container/resource_container_cluster_cai2hcl.go

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -122,8 +122,6 @@ func (c *ContainerClusterCai2hclConverter) convertResourceData(asset caiasset.As
122122
hclData["node_locations"] = locations
123123
}
124124
}
125-
hclData["min_master_version"] = asset.Resource.Data["currentNodeVersion"]
126-
hclData["node_version"] = asset.Resource.Data["currentNodeVersion"]
127125
hclData["logging_service"] = asset.Resource.Data["loggingService"]
128126
hclData["monitoring_service"] = asset.Resource.Data["monitoringService"]
129127
hclData["node_config"] = flattenNodeConfig(asset.Resource.Data["nodeConfig"], nil)
@@ -1177,18 +1175,21 @@ func flattenClusterAutoscaling(v interface{}, enableAutopilot bool) []map[string
11771175
if !enableAutopilot {
11781176
transformed["enabled"] = true
11791177
}
1180-
} else if !enableAutopilot {
1181-
transformed["enabled"] = false
1178+
transformed["auto_provisioning_defaults"] = flattenAutoProvisioningDefaults(a["autoprovisioningNodePoolDefaults"])
1179+
}
1180+
if v := a["autoprovisioningLocations"]; v != nil {
1181+
transformed["auto_provisioning_locations"] = v
11821182
}
1183-
transformed["auto_provisioning_defaults"] = flattenAutoProvisioningDefaults(a["autoprovisioningNodePoolDefaults"])
1184-
transformed["auto_provisioning_locations"] = a["autoprovisioningLocations"]
11851183
if v := a["autoscalingProfile"]; v != nil && v != "BALANCED" {
11861184
transformed["autoscaling_profile"] = v
11871185
}
11881186
if dccc, ok := a["defaultComputeClassConfig"].(map[string]interface{}); ok {
11891187
transformed["default_compute_class_enabled"] = dccc["enabled"]
11901188
}
11911189

1190+
if len(transformed) == 0 {
1191+
return nil
1192+
}
11921193
return []map[string]interface{}{transformed}
11931194
}
11941195

0 commit comments

Comments
 (0)