tgc-revival: skip TestAccSpannerInstance_basicWithAutoscalingUsingNodeConfigUpdateDisableAutoscaling (GoogleCloudPlatform#16275)

Author: zli82016

mmv1/products/spanner/Instance.yaml

@@ -74,6 +74,9 @@ virtual_fields:
       This must be set to true if you created a backup manually in the console.
     type: Boolean
     default_value: false
+tgc_tests:
+  - name: 'TestAccSpannerInstance_basicWithAutoscalingUsingNodeConfigUpdateDisableAutoscaling'
+    skip: 'sometimes the CAI asset data for step3 is unavailable'
 parameters:
 properties:
   - name: 'name'

mmv1/provider/terraform_tgc_next.go

@@ -377,15 +377,15 @@ func (tgc TerraformGoogleConversionNext) addTestsFromHandwrittenTests(object *ap
 	}
 
 	matches := testRegex.FindAllSubmatch(data, -1)
-	tests := make([]resource.TGCTest, len(matches))
-	for i, match := range matches {
+	tests := make([]resource.TGCTest, 0)
+	for _, match := range matches {
 		if len(match) == 2 {
 			if _, ok := testNamesInYAML[string(match[1])]; ok {
 				continue
 			}
-			tests[i] = resource.TGCTest{
+			tests = append(tests, resource.TGCTest{
 				Name: string(match[1]),
-			}
+			})
 		}
 	}